Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/resources/settings/device_page/storage.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/storage.html
diff --git a/chrome/browser/resources/settings/device_page/storage.html b/chrome/browser/resources/settings/device_page/storage.html
index 32a1b88a5871ba9e096080b9579015693a058b21..3361b87087d5f5a1965cc93869a6cce56ade43cf 100644
--- a/chrome/browser/resources/settings/device_page/storage.html
+++ b/chrome/browser/resources/settings/device_page/storage.html
@@ -183,7 +183,9 @@
<div id="downloadsSize" class="storage-size">
$i18n{storageSizeComputing}
</div>
- <button class="icon-external" is="paper-icon-button-light"></button>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{storageItemDownloads}"
+ aria-describedby="downloadsSize"></button>
</div>
<template is="dom-if" if="[[driveEnabled_]]">
<div class="settings-box" on-tap="onDriveCacheTap_" actionable>
@@ -191,7 +193,9 @@
<div id="driveCacheSize" class="storage-size">
$i18n{storageSizeComputing}
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{storageItemDriveCache}"
+ aria-describedby="driveSizeCache"></button>
</div>
</template>
<div class="settings-box" on-tap="onBrowsingDataTap_" actionable>
@@ -199,7 +203,9 @@
<div id="browsingDataSize" class="storage-size">
$i18n{storageSizeComputing}
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{storageItemBrowsingData}"
+ aria-describedby="browsingDataSize"></button>
</div>
<template is="dom-if" if="[[androidEnabled_]]">
<div class="settings-box" on-tap="onAndroidTap_" actionable>
@@ -207,7 +213,9 @@
<div id="androidSize" class="storage-size">
$i18n{storageSizeComputing}
</div>
- <button class="icon-external" is="paper-icon-button-light"></button>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{storageItemAndroid}"
+ aria-describedby="androidSize"></button>
</div>
</template>
<template is="dom-if" if="[[!isGuest_]]">
@@ -216,7 +224,9 @@
<div id="otherUsersSize" class="storage-size">
$i18n{storageSizeComputing}
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{storageItemOtherUsers}"
+ aria-describedby="otherUsersSize"></button>
</div>
</template>
« no previous file with comments | « chrome/browser/resources/settings/device_page/keyboard.html ('k') | chrome/browser/resources/settings/device_page/stylus.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698