Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2920)

Unified Diff: chrome/browser/resources/settings/device_page/keyboard.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/keyboard.html
diff --git a/chrome/browser/resources/settings/device_page/keyboard.html b/chrome/browser/resources/settings/device_page/keyboard.html
index 075525a7adcdd58166ffd9d7436e74d0a6b19d21..b57ec09c6360deb02e1dfc2a596e9e926bd6a85d 100644
--- a/chrome/browser/resources/settings/device_page/keyboard.html
+++ b/chrome/browser/resources/settings/device_page/keyboard.html
@@ -109,11 +109,13 @@
<div id="keyboardOverlay" class="settings-box"
on-tap="onShowKeyboardShortcutsOverlayTap_" actionable>
<div class="start">$i18n{showKeyboardShortcutsOverlay}</div>
- <button class="icon-external" is="paper-icon-button-light"></button>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{showKeyboardShortcutsOverlay}"></button>
</div>
<div class="settings-box" on-tap="onShowLanguageInputTap_" actionable>
<div class="start">$i18n{keyboardShowLanguageAndInput}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{keyboardShowLanguageAndInput}"></button>
</div>
</template>
<script src="keyboard.js"></script>
« no previous file with comments | « chrome/browser/resources/settings/device_page/display.html ('k') | chrome/browser/resources/settings/device_page/storage.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698