Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: chrome/browser/resources/settings/printing_page/printing_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/printing_page.html
diff --git a/chrome/browser/resources/settings/printing_page/printing_page.html b/chrome/browser/resources/settings/printing_page/printing_page.html
index 85f5e26fb55e83522a1a6623e24b68c391afa2a9..dbfa5cf78c4124b9c27343c5045bce4fb7557cf2 100644
--- a/chrome/browser/resources/settings/printing_page/printing_page.html
+++ b/chrome/browser/resources/settings/printing_page/printing_page.html
@@ -23,10 +23,9 @@
<template is="dom-if" if="[[showCupsPrintingFeatures_]]">
<div id="cupsPrinters" class="settings-box first"
on-tap="onTapCupsPrinters_" actionable>
- <div class="start">
- $i18n{cupsPrintersTitle}
- </div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <div class="start">$i18n{cupsPrintersTitle}</div>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{cupsPrintersTitle}"></button>
</div>
</template>
</if>
@@ -34,9 +33,13 @@
on-tap="onTapCloudPrinters_" actionable>
<div class="start">
$i18n{cloudPrintersTitle}
- <div class="secondary">$i18n{cloudPrintersTitleDescription}</div>
+ <div class="secondary" id="cloudPrintersSecondary">
+ $i18n{cloudPrintersTitleDescription}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{cloudPrintersTitle}"
+ aria-describedby="cloudPrintersSecondary"></button>
</div>
</neon-animatable>
<if expr="chromeos">

Powered by Google App Engine
This is Rietveld 408576698