Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/resources/settings/device_page/display.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/display.html
diff --git a/chrome/browser/resources/settings/device_page/display.html b/chrome/browser/resources/settings/device_page/display.html
index 81e67639fc3e407d79e0913ce1f79a1dbe66b16c..45e588eb282bc5811719bd24cdaead8aa7eba1d2 100644
--- a/chrome/browser/resources/settings/device_page/display.html
+++ b/chrome/browser/resources/settings/device_page/display.html
@@ -134,10 +134,14 @@
on-tap="onOverscanTap_" hidden$="[[selectedDisplay.isInternal]]"
actionable>
<div class="start">
- <div>$i18n{displayOverscanPageTitle}</div>
- <div class="secondary">$i18n{displayOverscanPageText}</div>
+ $i18n{displayOverscanPageTitle}
+ <div class="secondary" id="displayOverscanSecondary">
+ $i18n{displayOverscanPageText}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{displayOverscanPageTitle}"
+ aria-describedby="displayOverscanSecondary"></button>
</div>
<settings-display-overscan-dialog id="displayOverscan"
@@ -149,10 +153,14 @@
hidden$="[[!showTouchCalibrationSetting_(selectedDisplay)]]"
actionable>
<div class="start">
- <div>$i18n{displayTouchCalibrationTitle}</div>
- <div class="secondary">$i18n{displayTouchCalibrationText}</div>
+ $i18n{displayTouchCalibrationTitle}
+ <div class="secondary" id="touchCalibrationSecondary">
+ $i18n{displayTouchCalibrationText}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{displayTouchCalibrationTitle}"
+ aria-describedby="touchCalibrationSecondary"></button>
</div>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698