Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5939)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index f1d1a282442aaa696f5502301b5408e895102fc2..a54f6a1235321fdf0234b905fe4f8ffaee7e6988 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -161,13 +161,19 @@
actionable on-tap="onManageCertificatesTap_">
<div class="start">
$i18n{manageCertificates}
- <div class="secondary">$i18n{manageCertificatesDescription}</div>
+ <div class="secondary" id="manageCertificatesSecondary">
+ $i18n{manageCertificatesDescription}
+ </div>
</div>
<if expr="use_nss_certs">
- <button is="paper-icon-button-light" class="subpage-arrow"></button>
+ <button is="paper-icon-button-light" class="subpage-arrow"
+ aria-label="$i18n{manageCertificates}"
+ aria-describedby="manageCertificatesSecondary"></button>
</if>
<if expr="not use_nss_certs">
- <button is="paper-icon-button-light" class="icon-external"></button>
+ <button is="paper-icon-button-light" class="icon-external"
+ aria-label="$i18n{manageCertificates}"
+ aria-describedby="manageCertificatesSecondary"></button>
</if>
</div>
</if>
@@ -176,17 +182,25 @@
on-tap="onSiteSettingsTap_">
<div class="start">
[[siteSettingsPageTitle_()]]
- <div class="secondary">$i18n{siteSettingsDescription}</div>
+ <div class="secondary" id="siteSettingsSecondary">
+ $i18n{siteSettingsDescription}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="[[siteSettingsPageTitle_()]]"
+ aria-describedby="siteSettingsSecondary"></button>
</div>
<div class="settings-box two-line" id="clearBrowsingData"
on-tap="onClearBrowsingDataTap_" actionable>
<div class="start">
$i18n{clearBrowsingData}
- <div class="secondary">$i18n{clearBrowsingDataDescription}</div>
+ <div class="secondary" id="clearBrowsingDataSecondary">
+ $i18n{clearBrowsingDataDescription}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{clearBrowsingData}"
+ aria-describedby="clearBrowsingDataSecondary"></button>
</div>
</neon-animatable>
<if expr="use_nss_certs">
@@ -362,10 +376,9 @@
<if expr="chromeos">
<div actionable class="settings-box"
on-tap="onAdobeFlashStorageClicked_">
- <div class="start">
- $i18n{adobeFlashStorage}
- </div>
- <button class="icon-external" is="paper-icon-button-light"></button>
+ <div class="start">$i18n{adobeFlashStorage}</div>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{adobeFlashStorage}"></button>
</div>
</if>
<category-setting-exceptions

Powered by Google App Engine
This is Rietveld 408576698