chrome/browser/resources/settings/about_page/about_page.html - Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)

Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/a11y_page/manage_a11y_page.html ('k') | chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/about_page.html

diff --git a/chrome/browser/resources/settings/about_page/about_page.html b/chrome/browser/resources/settings/about_page/about_page.html

index b3005df0c4d3ee8fb42d853f8b788e0743d1fe15..3e4f02952002eceba0941e2c5fd70f26d49ca3e6 100644

--- a/chrome/browser/resources/settings/about_page/about_page.html

+++ b/chrome/browser/resources/settings/about_page/about_page.html

@@ -154,29 +154,31 @@

</div>

<button class="subpage-arrow" is="paper-icon-button-light"

disabled="[[promoteUpdaterStatus_.disabled]]"

- hidden="[[!promoteUpdaterStatus_.actionable]]">

+ hidden="[[!promoteUpdaterStatus_.actionable]]"

+ aria-label="[[promoteUpdaterStatus_.text]]">

</button>

</div>

</template>

</if>

<div class="start">$i18n{aboutGetHelpUsingChrome}</div>

- <button class="icon-external" is="paper-icon-button-light">

- </button>

+ <button class="icon-external" is="paper-icon-button-light"

+ aria-labelledby="help"></button>

</div>

<div id="reportIssue" class="settings-box" actionable

on-tap="onReportIssueTap_">

<div class="start">$i18n{aboutReportAnIssue}</div>

- <button class="subpage-arrow" is="paper-icon-button-light">

- </button>

+ <button class="subpage-arrow" is="paper-icon-button-light"

+ aria-labelledby="reportIssue"></button>

</div>

</if>

<div class="settings-box" on-tap="onDetailedBuildInfoTap_"

actionable>

<div class="start">$i18n{aboutDetailedBuildInfo}</div>

- <button class="subpage-arrow" is="paper-icon-button-light">

+ <button class="subpage-arrow" is="paper-icon-button-light"

+ aria-label="$i18n{aboutDetailedBuildInfo}">

</button>

</div>

</if>