Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: chrome/browser/resources/settings/device_page/device_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/device_page.html
diff --git a/chrome/browser/resources/settings/device_page/device_page.html b/chrome/browser/resources/settings/device_page/device_page.html
index 1665552a5c9213cb9f69f278d8234dfc6d653b63..9e7e6b591f38abc297eee35584501dad0d43de6d 100644
--- a/chrome/browser/resources/settings/device_page/device_page.html
+++ b/chrome/browser/resources/settings/device_page/device_page.html
@@ -26,29 +26,35 @@
<div class="middle">
[[getPointersTitle_(hasMouse_, hasTouchpad_)]]
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="[[getPointersTitle_(hasMouse_,
+ hasTouchpad_)]]"></button>
</div>
<div id="keyboardRow" class="settings-box" on-tap="onKeyboardTap_"
actionable>
<div class="middle">$i18n{keyboardTitle}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{keyboardTitle}"></button>
</div>
<template is="dom-if" if="[[hasStylus_]]">
<div id="stylusRow" class="settings-box" on-tap="onStylusTap_"
actionable>
<div class="middle">$i18n{stylusTitle}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{stylusTitle}"></button>
</div>
</template>
<div id="displayRow" class="settings-box" on-tap="onDisplayTap_"
actionable>
<div class="middle">$i18n{displayTitle}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{displayTitle}"></button>
</div>
<div id="storageRow" class="settings-box" on-tap="onStorageTap_"
actionable>
<div class="middle">$i18n{storageTitle}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{storageTitle}"></button>
</div>
<template is="dom-if" if="[[enablePowerSettings_]]">
<div id="powerRow" class="settings-box two-line">

Powered by Google App Engine
This is Rietveld 408576698