chrome/browser/resources/settings/search_page/search_page.html - Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)

Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_page.html ('k') | chrome/browser/resources/settings/site_settings/site_data.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_page/search_page.html

diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html

index fdbaac1e52909e651e4605042ef1a07a835f77f9..d1beb976806c75867464e44ad7bcd0a5950b652e 100644

--- a/chrome/browser/resources/settings/search_page/search_page.html

+++ b/chrome/browser/resources/settings/search_page/search_page.html

@@ -105,16 +105,16 @@

<div class="settings-box two-line continuation indented"

on-tap="onManageAudioHistoryTap_" actionable>

- <div>

- [[i18n('searchOkGoogleAudioHistoryLabel',

- hotwordInfo_.userName)]]

- </div>

- <div class="secondary">

+ [[i18n('searchOkGoogleAudioHistoryLabel',

+ hotwordInfo_.userName)]]

+ <div class="secondary" id="audioHistorySecondary">

$i18n{searchOkGoogleAudioHistorySubtext}

</div>

- <button class="icon-external" is="paper-icon-button-light">

- </button>

+ <button class="icon-external" is="paper-icon-button-light"

+ aria-label="[[i18n('searchOkGoogleAudioHistoryLabel',

+ hotwordInfo_.userName)]]"

+ aria-describedby="audioHistorySecondary"></button>

</div>

</template>

@@ -124,11 +124,13 @@

on-tap="onManageSearchEnginesTap_" actionable>

$i18n{searchEnginesManage}

- <div class="secondary">

+ <div class="secondary" id="manageSearchEnginesSecondary">

$i18n{searchEnginesManageDescription}

</div>

- <button class="subpage-arrow" is="paper-icon-button-light"></button>

+ <button class="subpage-arrow" is="paper-icon-button-light"

+ aria-label="$i18n{searchEnginesManage}"

+ aria-describedby="manageSearchEnginesSecondary"></button>

</div>

</neon-animatable>