Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 0f5fe6cde0a1b2f38ad4c1c7d7001513045363d1..1fbbd0e9fdc294d2440bb64876f97406b2236dc4 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -123,12 +123,14 @@
</if>
<div class="flex text-elide">
<span id="profile-name">[[profileName_]]</span>
- <div class="secondary" hidden="[[!syncStatus.signedIn]]">
+ <div class="secondary" hidden="[[!syncStatus.signedIn]]"
+ id="profileNameSecondary">
[[syncStatus.signedInUsername]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light">
- </button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-labelledby="profile-name"
+ aria-describedby="profileNameSecondary"></button>
</div>
<if expr="not chromeos">
<template is="dom-if" if="[[showSignin_(syncStatus)]]">
@@ -184,12 +186,15 @@
</iron-icon>
</div>
<div class="middle">
- <div>$i18n{sync}</div>
- <div class$="secondary [[getSyncStatusTextClass_(syncStatus)]]">
+ $i18n{sync}
+ <div class$="secondary [[getSyncStatusTextClass_(syncStatus)]]"
+ id="syncSecondary">
[[syncStatus.statusText]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{sync}"
+ aria-describedby="syncSecondary"></button>
</div>
</template>
@@ -200,10 +205,14 @@
<div id="googleg-logo"></div>
</div>
<div class="middle">
- <div>$i18n{personalizeGoogleServicesTitle}</div>
- <div class="secondary">$i18n{personalizeGoogleServicesText}</div>
+ $i18n{personalizeGoogleServicesTitle}
+ <div class="secondary" id="personalizeGoogleServicesSecondary">
+ $i18n{personalizeGoogleServicesText}
+ </div>
</div>
- <button class="icon-external" is="paper-icon-button-light"></button>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{personalizeGoogleServicesTitle}"
+ aria-describedby="personalizeGoogleServicesSecondary"></button>
</div>
<if expr="chromeos">
@@ -221,12 +230,14 @@
on-tap="onConfigureLockTap_">
<div class="start">
$i18n{lockScreenTitle}
- <div class="secondary">
+ <div class="secondary" id="lockScreenSecondary">
[[getPasswordState_(hasPin,
prefs.settings.enable_screen_lock.value)]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{lockScreenTitle}"
+ aria-describedby="lockScrenSecondary"></button>
</div>
</template>
@@ -278,13 +289,15 @@
<div id="manage-other-people-subpage-trigger"
class="settings-box" on-tap="onManageOtherPeople_" actionable>
<div class="start">$i18n{manageOtherPeople}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{manageOtherPeople}"></button>
</div>
<if expr="not chromeos">
<div class="settings-box" on-tap="onImportDataTap_" actionable>
<div class="start">$i18n{importTitle}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{importTitle}"></button>
</div>
</if>
@@ -293,11 +306,13 @@
on-tap="onManageSupervisedUsers_" actionable>
<div class="start">
$i18n{manageSupervisedUsers}
- <div class="secondary">
+ <div class="secondary" id="manageSupervisedUsersSecondary">
$i18n{manageSupervisedUsersDescription}
</div>
</div>
- <button class="icon-external" is="paper-icon-button-light"></button>
+ <button class="icon-external" is="paper-icon-button-light"
+ aria-label="$i18n{manageSupervisedUsers}"
+ aria-describedby="manageSupervisedUsersSecondary"></button>
</div>
</template>
</neon-animatable>

Powered by Google App Engine
This is Rietveld 408576698