Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4257)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
index 5cd0d26ecd8c679eecb52264881ebd351935352b..7b1406561c8abd6cb064606a00ea7059bf71fa83 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
@@ -20,7 +20,8 @@
data-route="SITE_SETTINGS_ALL" on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:list"></iron-icon>
<div class="middle">$i18n{siteSettingsCategoryAllSites}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsCategoryAllSites}"></button>
</div>
<div class="settings-box line-only">
</div>
@@ -30,8 +31,8 @@
data-route="SITE_SETTINGS_COOKIES" on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:cookie"></iron-icon>
<div class="middle">
- <div>$i18n{siteSettingsCookies}</div>
- <div class="secondary">
+ $i18n{siteSettingsCookies}
+ <div class="secondary" id="cookiesSecondary">
[[defaultSettingLabel_(
default_.cookies,
'$i18n{siteSettingsCookiesAllowed}',
@@ -39,22 +40,26 @@
'$i18n{deleteDataPostSession}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsCookies}"
+ aria-describedby="cookiesSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.GEOLOCATION]]"
data-route="SITE_SETTINGS_LOCATION" on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:location-on"></iron-icon>
<div class="middle">
- <div>$i18n{siteSettingsLocation}</div>
- <div class="secondary">
+ $i18n{siteSettingsLocation}
+ <div class="secondary" id="locationSecondary">
[[defaultSettingLabel_(
default_.location,
'$i18n{siteSettingsAskBeforeAccessing}',
'$i18n{siteSettingsBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsLocation}"
+ aria-describedby="locationSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.CAMERA]]"
@@ -62,15 +67,17 @@
on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:videocam"></iron-icon>
<div class="middle">
- <div>$i18n{siteSettingsCamera}</div>
- <div class="secondary">
+ $i18n{siteSettingsCamera}
+ <div class="secondary" id="cameraSecondary">
[[defaultSettingLabel_(
default_.mediaStreamCamera,
'$i18n{siteSettingsAskBeforeAccessing}',
'$i18n{siteSettingsBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsCamera}"
+ aria-describedby="cameraSecondary"></button>
</div>
<div class="settings-box two-line" category$="[[ContentSettingsTypes.MIC]]"
data-route="SITE_SETTINGS_MICROPHONE" on-tap="onTapNavigate_"
@@ -78,14 +85,16 @@
<iron-icon icon="settings:mic"></iron-icon>
<div class="middle">
$i18n{siteSettingsMic}
- <div class="secondary">
+ <div class="secondary" id="micSecondary">
[[defaultSettingLabel_(
default_.mediaStreamMic,
'$i18n{siteSettingsAskBeforeAccessing}',
'$i18n{siteSettingsBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsMic}"
+ aria-describedby="micSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.NOTIFICATIONS]]"
@@ -94,14 +103,16 @@
<iron-icon icon="settings:notifications"></iron-icon>
<div class="middle">
$i18n{siteSettingsNotifications}
- <div class="secondary">
+ <div class="secondary" id="notificationsSecondary">
[[defaultSettingLabel_(
default_.notifications,
'$i18n{siteSettingsAskBeforeSending}',
'$i18n{siteSettingsBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsNotifications}"
+ aria-describedby="notificationsSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.JAVASCRIPT]]"
@@ -110,14 +121,16 @@
<iron-icon icon="settings:input"></iron-icon>
<div class="middle">
$i18n{siteSettingsJavascript}
- <div class="secondary">
+ <div class="secondary" is="javascriptSecondary">
[[defaultSettingLabel_(
default_.javascript,
'$i18n{siteSettingsAllowed}',
'$i18n{siteSettingsBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsJavascript}"
+ aria-describedby="javascriptSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.PLUGINS]]"
@@ -125,7 +138,7 @@
<iron-icon icon="cr:extension"></iron-icon>
<div class="middle">
$i18n{siteSettingsFlash}
- <div class="secondary">
+ <div class="secondary" id="flashSecondary">
[[defaultSettingLabel_(
default_.plugins,
'$i18n{siteSettingsFlashAllow}',
@@ -133,7 +146,9 @@
'$i18n{siteSettingsFlashAskBefore}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsFlash}"
+ aria-describedby="flashSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.IMAGES]]"
@@ -141,14 +156,16 @@
<iron-icon icon="settings:photo"></iron-icon>
<div class="middle">
$i18n{siteSettingsImages}
- <div class="secondary">
+ <div class="secondary" id="imagesSecondary">
[[defaultSettingLabel_(
default_.images,
'$i18n{siteSettingsShowAll}',
'$i18n{siteSettingsDontShowImages}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsImages}"
+ aria-describedby="imagesSecondary"></button>
</div>
<div category$="[[ContentSettingsTypes.POPUPS]]"
class="settings-box two-line" data-route="SITE_SETTINGS_POPUPS"
@@ -156,14 +173,16 @@
<iron-icon icon="cr:open-in-new"></iron-icon>
<div class="middle">
$i18n{siteSettingsPopups}
- <div class="secondary">
+ <div class="secondary" id="popupsSecondary">
[[defaultSettingLabel_(
default_.popups,
'$i18n{siteSettingsAllowed}',
'$i18n{siteSettingsBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsPopups}"
+ aria-describedby="popupsSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.BACKGROUND_SYNC]]"
@@ -172,14 +191,16 @@
<iron-icon icon="settings:sync"></iron-icon>
<div class="middle">
$i18n{siteSettingsBackgroundSync}
- <div class="secondary">
+ <div class="secondary" id="backgroundSyncSecondary">
[[defaultSettingLabel_(
default_.backgroundSync,
'$i18n{siteSettingsAllowRecentlyClosedSites}',
'$i18n{siteSettingsBackgroundSyncBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsBackgroundSync}"
+ aria-describedby="backgroundSyncSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.AUTOMATIC_DOWNLOADS]]"
@@ -188,14 +209,16 @@
<iron-icon icon="cr:file-download"></iron-icon>
<div class="middle">
$i18n{siteSettingsAutomaticDownloads}
- <div class="secondary">
+ <div class="secondary" id="automaticDownloadsSecondary">
[[defaultSettingLabel_(
default_.multipleAutomaticDownloads,
'$i18n{siteSettingsAutoDownloadAsk}',
'$i18n{siteSettingsAutoDownloadBlock}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsAutomaticDownloads}"
+ aria-describedby="automaticDownloadsSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.UNSANDBOXED_PLUGINS]]"
@@ -204,14 +227,16 @@
<iron-icon icon="cr:extension"></iron-icon>
<div class="middle">
$i18n{siteSettingsUnsandboxedPlugins}
- <div class="secondary">
+ <div class="secondary" id="unsandboxedPluginsSecondary">
[[defaultSettingLabel_(
default_.ppapiBroker,
'$i18n{siteSettingsUnsandboxedPluginsAsk}',
'$i18n{siteSettingsUnsandboxedPluginsBlock}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsUnsandboxedPlugins}"
+ aria-describedby="unsandboxedPluginsSecondary"></button>
</div>
<div class="settings-box two-line"
category$="[[ContentSettingsTypes.PROTOCOL_HANDLERS]]"
@@ -220,40 +245,46 @@
<iron-icon icon="settings:protocol-handler"></iron-icon>
<div class="middle">
$i18n{siteSettingsHandlers}
- <div class="secondary">
+ <div class="secondary" id="handlersSecondary">
[[defaultSettingLabel_(
default_.registerProtocolHandler,
'$i18n{siteSettingsHandlersAsk}',
'$i18n{siteSettingsHandlersBlocked}')]]
</div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsHandlers}"
+ aria-describedby="handlersSecondary"></button>
</div>
<div class="settings-box" category$="[[ContentSettingsTypes.ZOOM_LEVELS]]"
data-route="SITE_SETTINGS_ZOOM_LEVELS"
on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:zoom-in"></iron-icon>
<div class="middle">$i18n{siteSettingsZoomLevels}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsZoomLevels}"></button>
</div>
<div class="settings-box" category$="[[ContentSettingsTypes.USB_DEVICES]]"
data-route="SITE_SETTINGS_USB_DEVICES"
on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:usb"></iron-icon>
<div class="middle">$i18n{siteSettingsUsbDevices}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsUsbDevices}"></button>
</div>
<div class="settings-box" data-route="SITE_SETTINGS_PDF_DOCUMENTS"
on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:pdf"></iron-icon>
<div class="middle">$i18n{siteSettingsPdfDocuments}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsPdfDocuments}"></button>
</div>
<div class="settings-box" data-route="SITE_SETTINGS_PROTECTED_CONTENT"
on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:security"></iron-icon>
<div class="middle">$i18n{siteSettingsProtectedContent}</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{siteSettingsProtectedContent}"></button>
</div>
</template>
<script src="site_settings_page.js"></script>
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698