PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1][2][3].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84
[2] https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
[3] https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent

BUG=661608
Review-Url: https://codereview.chromium.org/2665583002
Cr-Commit-Position: refs/heads/master@{#447236}
Committed: https://chromium.googlesource.com/chromium/src/+/43a4fa9fea854962de09320188f93f169fc117ae

[zino, 2017-01-29 06:47:24]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 06:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 08:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 08:24:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zino, 2017-01-29 20:51:08]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 20:51:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2017-01-29 20:51:31]

Description was changed from

==========
PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84

BUG=661608
==========

to

==========
PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84

BUG=661608
==========

[zino, 2017-01-29 20:51:31]

jinho.bang@samsung.com changed reviewers:
+ haraken@chromium.org, rouslan@chromium.org

[zino, 2017-01-29 20:53:10]

PTAL

This CL doesn't need a intent because Payment App API is still behind runtime
flag.

[zino, 2017-01-29 21:23:03]

jinho.bang@samsung.com changed reviewers:
+ avi@chromium.org, tsepez@chromium.org

[zino, 2017-01-29 21:27:19]

jinho.bang@samsung.com changed reviewers:
+ jam@chromium.org
- avi@chromium.org

[zino, 2017-01-29 21:28:53]

PTAL

haraken@ for Blink/*
rouslan@ for payments
jam@ for content/*
Tom Sepez@ for mojom

[zino, 2017-01-29 21:29:38]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 21:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 21:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 21:54:41]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[zino, 2017-01-30 02:25:18]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 02:25:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 04:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 04:28:24]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-01-30 15:03:32]

payments lgtm % comments

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl (right):

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl:5: //
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
Please put this URL in CL description as well.

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.h
(right):

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.h:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
2017 (looks like a new file)

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl (right):

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl:5: //
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent
Please put this URL in the CL description as well.

[jam, 2017-01-30 18:05:01]

lgtm with nits

https://codereview.chromium.org/2665583002/diff/60001/chrome/browser/android/...
File chrome/browser/android/payments/service_worker_payment_app_bridge.cc
(right):

https://codereview.chromium.org/2665583002/diff/60001/chrome/browser/android/...
chrome/browser/android/payments/service_worker_payment_app_bridge.cc:99:
PaymentAppRequestPtr appRequest = PaymentAppRequest::New();
ditto

https://codereview.chromium.org/2665583002/diff/60001/content/browser/payment...
File content/browser/payments/payment_app_provider_impl.cc (right):

https://codereview.chromium.org/2665583002/diff/60001/content/browser/payment...
content/browser/payments/payment_app_provider_impl.cc:52:
payments::mojom::PaymentAppRequestPtr appRequest,
app_request per style guide

https://codereview.chromium.org/2665583002/diff/60001/content/browser/payment...
File content/browser/payments/payment_app_provider_impl_unittest.cc (right):

https://codereview.chromium.org/2665583002/diff/60001/content/browser/payment...
content/browser/payments/payment_app_provider_impl_unittest.cc:54:
payments::mojom::PaymentAppRequestPtr appRequest) {
ditto in this file as well

https://codereview.chromium.org/2665583002/diff/60001/content/browser/service...
File content/browser/service_worker/embedded_worker_test_helper.cc (right):

https://codereview.chromium.org/2665583002/diff/60001/content/browser/service...
content/browser/service_worker/embedded_worker_test_helper.cc:177:
payments::mojom::PaymentAppRequestPtr appRequest,
ditto this file

https://codereview.chromium.org/2665583002/diff/60001/content/common/service_...
File content/common/service_worker/service_worker_event_dispatcher.mojom
(right):

https://codereview.chromium.org/2665583002/diff/60001/content/common/service_...
content/common/service_worker/service_worker_event_dispatcher.mojom:55:
DispatchPaymentRequestEvent(payments.mojom.PaymentAppRequest appRequest)
ditto

https://codereview.chromium.org/2665583002/diff/60001/content/public/browser/...
File content/public/browser/payment_app_provider.h (right):

https://codereview.chromium.org/2665583002/diff/60001/content/public/browser/...
content/public/browser/payment_app_provider.h:41:
payments::mojom::PaymentAppRequestPtr appRequest) = 0;
ditto

https://codereview.chromium.org/2665583002/diff/60001/content/renderer/servic...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/2665583002/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.cc:869:
payments::mojom::PaymentAppRequestPtr appRequest,
ditto

https://codereview.chromium.org/2665583002/diff/60001/content/renderer/servic...
File content/renderer/service_worker/service_worker_context_client.h (right):

https://codereview.chromium.org/2665583002/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.h:226:
payments::mojom::PaymentAppRequestPtr appRequest,
ditto

https://codereview.chromium.org/2665583002/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.h:226:
payments::mojom::PaymentAppRequestPtr appRequest,
ditto

[haraken, 2017-01-30 18:10:24]

WebKit LGTM

[Tom Sepez, 2017-01-30 18:15:37]

mojom LGTM modulo style guidance.

[zino, 2017-01-31 09:05:10]

Description was changed from

==========
PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84

BUG=661608
==========

to

==========
PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1][2][3].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84
[2]
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
[3]
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent

BUG=661608
==========

[zino, 2017-01-31 09:16:07]

jam@ and rouslan@

I addressed your comments.

Thank you for review.

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl (right):

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl:5: //
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
On 2017/01/30 15:03:32, rouslan wrote:
> Please put this URL in CL description as well.

Done.

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.h
(right):

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.h:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/01/30 15:03:32, rouslan wrote:
> 2017 (looks like a new file)

IMHO, this change is just renaming, not adding a new file,
we probably should keep the year in the boilerplate even if the presubmit
recognizes it as a new file (because the file was written in 2016)

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl (right):

https://codereview.chromium.org/2665583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl:5: //
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent
On 2017/01/30 15:03:32, rouslan wrote:
> Please put this URL in the CL description as well.

Done.

[zino, 2017-01-31 09:16:17]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 09:16:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 11:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 11:10:21]

Dry run: This issue passed the CQ dry run.

[zino, 2017-01-31 15:39:02]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-01-31 15:39:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tsepez@chromium.org, rouslan@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2665583002/#ps80001
(title: "PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.")

[commit-bot: I haz the power, 2017-01-31 15:39:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 15:45:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485877142311260,
"parent_rev": "c5cdb47188549b4d5c9ce8905dc8d1edd797cd07", "commit_rev":
"43a4fa9fea854962de09320188f93f169fc117ae"}

[commit-bot: I haz the power, 2017-01-31 15:45:44]

Description was changed from

==========
PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1][2][3].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84
[2]
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
[3]
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent

BUG=661608
==========

to

==========
PaymentApp: Rename PaymentAppRequestData to PaymentAppRequest.

Recently, the name was changed in the spec[1][2][3].

[1] https://github.com/w3c/webpayments-payment-apps-api/pull/84
[2]
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
[3]
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentrequestevent

BUG=661608

Review-Url: https://codereview.chromium.org/2665583002
Cr-Commit-Position: refs/heads/master@{#447236}
Committed:
https://chromium.googlesource.com/chromium/src/+/43a4fa9fea854962de09320188f9...
==========

[commit-bot: I haz the power, 2017-01-31 15:45:45]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/43a4fa9fea854962de09320188f9...