create struct to hold all the params passed around for shader::context

create struct to hold all the params passed around for shader::context

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14514

[reed1, 2014-05-01 18:20:48]

This is somewhat easier to read as is (I think), but it definitely will make
future changes a lot easier (e.g. adding more state to ContextRec).

[scroggo, 2014-05-01 18:49:38]

lgtm

https://codereview.chromium.org/264843006/diff/1/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/264843006/diff/1/include/core/SkShader.h#newc...
include/core/SkShader.h:122: struct ContextRec {
Could you add some comments?

https://codereview.chromium.org/264843006/diff/1/src/core/SkBlitter.cpp
File src/core/SkBlitter.cpp (right):

https://codereview.chromium.org/264843006/diff/1/src/core/SkBlitter.cpp#newco...
src/core/SkBlitter.cpp:1035: bool SkShaderBlitter::resetShaderContext(const
SkBitmap& device, const SkPaint& paint,
This could take a ContextRec (although I think we can remove this function
anyway once you rewrite drawVertices, so maybe there's no need for the churn
here).

https://codereview.chromium.org/264843006/diff/1/src/core/SkBlitter.cpp#newco...
src/core/SkBlitter.cpp:1038: if
(!fShader->validContext(SkShader::ContextRec(rec))) {
Why did you need to make a copy here?

https://codereview.chromium.org/264843006/diff/1/src/core/SkPictureShader.h
File src/core/SkPictureShader.h (right):

https://codereview.chromium.org/264843006/diff/1/src/core/SkPictureShader.h#n...
src/core/SkPictureShader.h:27: virtual bool validContext(const ContextRec&,
SkMatrix* totalInverse = NULL) const SK_OVERRIDE;
Do you want to remove this default param?

[reed1, 2014-05-01 18:57:41]

https://codereview.chromium.org/264843006/diff/1/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/264843006/diff/1/include/core/SkShader.h#newc...
include/core/SkShader.h:122: struct ContextRec {
On 2014/05/01 18:49:38, scroggo wrote:
> Could you add some comments?

Done.

https://codereview.chromium.org/264843006/diff/1/src/core/SkBlitter.cpp
File src/core/SkBlitter.cpp (right):

https://codereview.chromium.org/264843006/diff/1/src/core/SkBlitter.cpp#newco...
src/core/SkBlitter.cpp:1035: bool SkShaderBlitter::resetShaderContext(const
SkBitmap& device, const SkPaint& paint,
On 2014/05/01 18:49:38, scroggo wrote:
> This could take a ContextRec (although I think we can remove this function
> anyway once you rewrite drawVertices, so maybe there's no need for the churn
> here).

Agreed. I think its somewhat coincidental that the signatures match.

https://codereview.chromium.org/264843006/diff/1/src/core/SkBlitter.cpp#newco...
src/core/SkBlitter.cpp:1038: if
(!fShader->validContext(SkShader::ContextRec(rec))) {
On 2014/05/01 18:49:38, scroggo wrote:
> Why did you need to make a copy here?

left-over from a local refactor. Done

https://codereview.chromium.org/264843006/diff/1/src/core/SkPictureShader.h
File src/core/SkPictureShader.h (right):

https://codereview.chromium.org/264843006/diff/1/src/core/SkPictureShader.h#n...
src/core/SkPictureShader.h:27: virtual bool validContext(const ContextRec&,
SkMatrix* totalInverse = NULL) const SK_OVERRIDE;
On 2014/05/01 18:49:38, scroggo wrote:
> Do you want to remove this default param?

Done.

[reed1, 2014-05-01 18:59:04]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-01 18:59:21]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/264843006/20001

[commit-bot: I haz the power, 2014-05-01 19:31:42]

Change committed as 14514