Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)

Created:
4 years ago by Theresa
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka, dominickn+watch_chromium.org, gogerald+paymentswatch_chromium.org, tburkard+watch_chromium.org, johnme+watch_chromium.org, browser-components-watch_chromium.org, agrieve+watch_chromium.org, posciak+watch_chromium.org, cbentzel+watch_chromium.org, awdf+watch_chromium.org, sebsg+autofillwatch_chromium.org, jam, rouslan+autofill_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, vabr+watchlistautofill_chromium.org, harkness+watch_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, ntp-dev+reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, rouslan+payments_chromium.org, lizeb+watch-custom-tabs_chromium.org, sync-reviews_chromium.org, feature-media-reviews_chromium.org, mathp+autofillwatch_chromium.org, donnd+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, gavinp+prer_chromium.org, twellington+watch_chromium.org, pkotwicz+watch_chromium.org, estade+watch_chromium.org, zpeng+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch InterruptedException in CriteriaHelper Catch the InterruptedException in CriteriaHelper#* and remove the throws declaration from methods that no longer need to declare it. BUG=673892 TBR=boliu@chromium.org Committed: https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04 Cr-Commit-Position: refs/heads/master@{#438892}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change OverviewModeBehaviorWatcher back to try/finally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -511 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 3 chunks +3 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java View 1 chunk +24 lines, -40 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/FocusedEditableTextFieldZoomTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/HistoryUITest.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java View 12 chunks +12 lines, -13 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/overlays/strip/TabStripTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 1 7 chunks +7 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java View 3 chunks +15 lines, -23 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTestBase.java View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtilsTest.java View 6 chunks +6 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java View 5 chunks +5 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java View 2 chunks +15 lines, -23 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerDisableIncognitoModeIntegrationTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivityTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java View 8 chunks +3 lines, -21 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java View 1 chunk +7 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelMergingTest.java View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java View 1 chunk +23 lines, -29 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java View 3 chunks +14 lines, -22 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java View 4 chunks +4 lines, -23 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ActivityUtils.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/FullscreenTestUtils.java View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/NewTabPageTestUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/OverviewModeBehaviorWatcher.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/TabStripUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/contextmenu/ContextMenuUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 7 chunks +7 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 4 chunks +4 lines, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 5 chunks +5 lines, -9 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java View 1 chunk +1 line, -5 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/ApplicationUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CriteriaHelper.java View 4 chunks +10 lines, -5 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java View 3 chunks +3 lines, -6 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Theresa
ptal
4 years ago (2016-12-14 23:02:29 UTC) #4
Ted C
lgtm https://codereview.chromium.org/2573263002/diff/1/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OverviewModeBehaviorWatcher.java File chrome/test/android/javatests/src/org/chromium/chrome/test/util/OverviewModeBehaviorWatcher.java (left): https://codereview.chromium.org/2573263002/diff/1/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OverviewModeBehaviorWatcher.java#oldcode79 chrome/test/android/javatests/src/org/chromium/chrome/test/util/OverviewModeBehaviorWatcher.java:79: } finally { we can keep this one
4 years ago (2016-12-15 18:40:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573263002/20001
4 years ago (2016-12-15 18:51:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 19:28:10 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-15 19:30:23 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/98ff981acebe329c1e8ac43c21970c3e70044b04
Cr-Commit-Position: refs/heads/master@{#438892}

Powered by Google App Engine
This is Rietveld 408576698