chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java - Issue 2573263002: Catch InterruptedException in CriteriaHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)

Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

index a922307b45db3b310f47dcbdeca53ca6c4aa2762..9abb21ade3da1dffe079e55d4c64239d565beb4e 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

@@ -31,7 +31,7 @@ public class ConnectivityTaskTest extends ConnectivityCheckerTestBase {

@MediumTest

@Feature({"Feedback"})

- public void testNormalCaseShouldWork() throws InterruptedException {

+ public void testNormalCaseShouldWork() {

final ConnectivityTask task = ThreadUtils.runOnUiThreadBlockingNoException(

new Callable<ConnectivityTask>() {

@Override

@@ -144,7 +144,7 @@ public class ConnectivityTaskTest extends ConnectivityCheckerTestBase {

@MediumTest

@Feature({"Feedback"})

- public void testTwoTimeoutsShouldFillInTheRest() throws InterruptedException {

+ public void testTwoTimeoutsShouldFillInTheRest() {

final ConnectivityTask task = ThreadUtils.runOnUiThreadBlockingNoException(

new Callable<ConnectivityTask>() {

@Override