Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.snackbar; 5 package org.chromium.chrome.browser.snackbar;
6 6
7 import android.test.suitebuilder.annotation.MediumTest; 7 import android.test.suitebuilder.annotation.MediumTest;
8 import android.test.suitebuilder.annotation.SmallTest; 8 import android.test.suitebuilder.annotation.SmallTest;
9 9
10 import org.chromium.base.ThreadUtils; 10 import org.chromium.base.ThreadUtils;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 @Override 44 @Override
45 public void startMainActivity() throws InterruptedException { 45 public void startMainActivity() throws InterruptedException {
46 SnackbarManager.setDurationForTesting(1000); 46 SnackbarManager.setDurationForTesting(1000);
47 startMainActivityOnBlankPage(); 47 startMainActivityOnBlankPage();
48 mManager = getActivity().getSnackbarManager(); 48 mManager = getActivity().getSnackbarManager();
49 } 49 }
50 50
51 @MediumTest 51 @MediumTest
52 @RetryOnFailure 52 @RetryOnFailure
53 public void testStackQueueOrder() throws InterruptedException { 53 public void testStackQueueOrder() {
54 final Snackbar stackbar = Snackbar.make("stack", mDefaultController, 54 final Snackbar stackbar = Snackbar.make("stack", mDefaultController,
55 Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR); 55 Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR);
56 final Snackbar queuebar = Snackbar.make("queue", mDefaultController, 56 final Snackbar queuebar = Snackbar.make("queue", mDefaultController,
57 Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_TEST_SNACKBAR); 57 Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_TEST_SNACKBAR);
58 ThreadUtils.runOnUiThread(new Runnable() { 58 ThreadUtils.runOnUiThread(new Runnable() {
59 @Override 59 @Override
60 public void run() { 60 public void run() {
61 mManager.showSnackbar(stackbar); 61 mManager.showSnackbar(stackbar);
62 } 62 }
63 }); 63 });
(...skipping 21 matching lines...) Expand all
85 CriteriaHelper.pollUiThread(new Criteria("Snackbar did not time out") { 85 CriteriaHelper.pollUiThread(new Criteria("Snackbar did not time out") {
86 @Override 86 @Override
87 public boolean isSatisfied() { 87 public boolean isSatisfied() {
88 return !mManager.isShowing(); 88 return !mManager.isShowing();
89 } 89 }
90 }); 90 });
91 } 91 }
92 92
93 @SmallTest 93 @SmallTest
94 @RetryOnFailure 94 @RetryOnFailure
95 public void testQueueStackOrder() throws InterruptedException { 95 public void testQueueStackOrder() {
96 final Snackbar stackbar = Snackbar.make("stack", mDefaultController, 96 final Snackbar stackbar = Snackbar.make("stack", mDefaultController,
97 Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR); 97 Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR);
98 final Snackbar queuebar = Snackbar.make("queue", mDefaultController, 98 final Snackbar queuebar = Snackbar.make("queue", mDefaultController,
99 Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_TEST_SNACKBAR); 99 Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_TEST_SNACKBAR);
100 ThreadUtils.runOnUiThread(new Runnable() { 100 ThreadUtils.runOnUiThread(new Runnable() {
101 @Override 101 @Override
102 public void run() { 102 public void run() {
103 mManager.showSnackbar(queuebar); 103 mManager.showSnackbar(queuebar);
104 } 104 }
105 }); 105 });
(...skipping 19 matching lines...) Expand all
125 }); 125 });
126 CriteriaHelper.pollUiThread(new Criteria("Snackbar did not time out") { 126 CriteriaHelper.pollUiThread(new Criteria("Snackbar did not time out") {
127 @Override 127 @Override
128 public boolean isSatisfied() { 128 public boolean isSatisfied() {
129 return !mManager.isShowing(); 129 return !mManager.isShowing();
130 } 130 }
131 }); 131 });
132 } 132 }
133 133
134 @SmallTest 134 @SmallTest
135 public void testDismissSnackbar() throws InterruptedException { 135 public void testDismissSnackbar() {
136 final Snackbar snackbar = Snackbar.make("stack", mDismissController, 136 final Snackbar snackbar = Snackbar.make("stack", mDismissController,
137 Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR); 137 Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR);
138 mDismissed = false; 138 mDismissed = false;
139 ThreadUtils.runOnUiThread(new Runnable() { 139 ThreadUtils.runOnUiThread(new Runnable() {
140 @Override 140 @Override
141 public void run() { 141 public void run() {
142 mManager.showSnackbar(snackbar); 142 mManager.showSnackbar(snackbar);
143 } 143 }
144 }); 144 });
145 CriteriaHelper.pollUiThread( 145 CriteriaHelper.pollUiThread(
(...skipping 11 matching lines...) Expand all
157 } 157 }
158 }); 158 });
159 CriteriaHelper.pollUiThread(new Criteria("Snackbar did not time out") { 159 CriteriaHelper.pollUiThread(new Criteria("Snackbar did not time out") {
160 @Override 160 @Override
161 public boolean isSatisfied() { 161 public boolean isSatisfied() {
162 return !mManager.isShowing() && mDismissed; 162 return !mManager.isShowing() && mDismissed;
163 } 163 }
164 }); 164 });
165 } 165 }
166 } 166 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698