chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java - Issue 2573263002: Catch InterruptedException in CriteriaHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)

Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java ('k') | chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java

index 8dead56f8351375baa3043552a5f0a4a899ec0ee..6b6ce25d589ca9559946c133824170c5571c674b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java

@@ -61,7 +61,7 @@ public class FindTest extends ChromeTabbedActivityTestBase {

/**

* Returns the FindResults text.

- private String waitForFindResults(String expectedResult) throws InterruptedException {

+ private String waitForFindResults(String expectedResult) {

final TextView findResults = (TextView) getActivity().findViewById(R.id.find_status);

assertNotNull(expectedResult);

assertNotNull(findResults);

@@ -87,7 +87,7 @@ public class FindTest extends ChromeTabbedActivityTestBase {

waitForFindInPageVisibility(true);

}

- private void waitForFindInPageVisibility(final boolean visible) throws InterruptedException {

+ private void waitForFindInPageVisibility(final boolean visible) {

CriteriaHelper.pollUiThread(new Criteria() {

@Override

public boolean isSatisfied() {

@@ -391,7 +391,7 @@ public class FindTest extends ChromeTabbedActivityTestBase {

waitForFindInPageVisibility(false);

}

- private void waitForIME(final boolean imePresent) throws InterruptedException {

+ private void waitForIME(final boolean imePresent) {

// Wait for IME to appear.

CriteriaHelper.pollUiThread(new Criteria("IME is not getting shown!") {

@Override