content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java - Issue 2573263002: Catch InterruptedException in CriteriaHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)

Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java b/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

index e33a47fd132557636b83a744a07a42dda65cc9b8..6dce98ef3a41d6ab9473320f9b26181156481a81 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

@@ -64,7 +64,7 @@ public class InterstitialPageTest extends ContentShellTestBase {

waitForActiveShellToBeDoneLoading();

}

- private void waitForInterstitial(final boolean shouldBeShown) throws InterruptedException {

+ private void waitForInterstitial(final boolean shouldBeShown) {

CriteriaHelper.pollUiThread(

Criteria.equals(shouldBeShown, new Callable<Boolean>() {

@Override

@@ -80,7 +80,7 @@ public class InterstitialPageTest extends ContentShellTestBase {

@LargeTest

@Feature({"Navigation"})

@RetryOnFailure

- public void testCloseInterstitial() throws InterruptedException, ExecutionException {

+ public void testCloseInterstitial() throws ExecutionException {

final String proceedCommand = "PROCEED";

final String htmlContent = "<html>"

+ "<head>"