Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
index 43bf65e625cc153c7322749b742683951bb38caa..0b0a592bf2d0886a5e87608e27209ec63779d5ad 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
@@ -114,7 +114,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {
@MediumTest
@Feature({"NewTabPage", "RenderTest"})
@CommandLineFlags.Add("enable-features=NTPSnippets")
- public void testRender() throws IOException, InterruptedException {
+ public void testRender() throws IOException {
ViewRenderer viewRenderer = new ViewRenderer(getActivity(),
"chrome/test/data/android/render_tests", "NewTabPageTest");
viewRenderer.renderAndCompare(mMostVisitedLayout, "most_visited");
@@ -404,8 +404,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {
});
}
- private void waitForUrlFocusAnimationsDisabledState(boolean disabled)
- throws InterruptedException {
+ private void waitForUrlFocusAnimationsDisabledState(boolean disabled) {
CriteriaHelper.pollInstrumentationThread(Criteria.equals(disabled, new Callable<Boolean>() {
@Override
public Boolean call() {
@@ -414,7 +413,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {
}));
}
- private void waitForTabLoading() throws InterruptedException {
+ private void waitForTabLoading() {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
@@ -427,8 +426,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {
waitForUrlFocusPercent(ntp, 1f);
}
- private void waitForUrlFocusPercent(final NewTabPage ntp, float percent)
- throws InterruptedException {
+ private void waitForUrlFocusPercent(final NewTabPage ntp, float percent) {
CriteriaHelper.pollUiThread(Criteria.equals(percent, new Callable<Float>() {
@Override
public Float call() {
@@ -460,8 +458,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {
/**
* Waits until the top of the fakebox reaches the given position.
*/
- private void waitForFakeboxTopPosition(final NewTabPage ntp, int position)
- throws InterruptedException {
+ private void waitForFakeboxTopPosition(final NewTabPage ntp, int position) {
CriteriaHelper.pollUiThread(Criteria.equals(position, new Callable<Integer>() {
@Override
public Integer call() {

Powered by Google App Engine
This is Rietveld 408576698