chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java - Issue 2573263002: Catch InterruptedException in CriteriaHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)

Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java

index 5e197a36b282270713fad03c3905f241263705b9..9b2898df89bc1589eb9f323d47fe22d5049c96c0 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java

@@ -28,7 +28,7 @@ public class CustomTabTabPersistenceIntegrationTest extends CustomTabActivityTes

}

@MediumTest

- public void testTabFilesDeletedOnClose() throws InterruptedException {

+ public void testTabFilesDeletedOnClose() {

Tab tab = getActivity().getActivityTab();

String expectedTabFileName = TabState.getTabStateFilename(tab.getId(), false);

String expectedMetadataFileName =

@@ -45,8 +45,7 @@ public class CustomTabTabPersistenceIntegrationTest extends CustomTabActivityTes

}

private void waitForFileExistState(

- final boolean exists, final String fileName, final File filePath)

- throws InterruptedException {

+ final boolean exists, final String fileName, final File filePath) {

CriteriaHelper.pollInstrumentationThread(new Criteria(

String.format(Locale.US, "File, %s, expected to exist: %b", fileName, exists)) {

@Override