Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2894)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
index bb900f21d1ebf55d6e79da7ed9c801fdd376730a..bec9fead8d082656a17ba8cc4969d21c3839c5da 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
@@ -49,34 +49,34 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr
simulateUpdateTitle(mTab, "title1");
}
- private void doTestSessionStatePlaying() throws InterruptedException {
+ private void doTestSessionStatePlaying() {
simulateMediaSessionStateChanged(mTab, true, false);
assertTitleMatches("title1");
simulateUpdateTitle(mTab, "title2");
assertTitleMatches("title2");
}
- private void doTestSessionStatePaused() throws InterruptedException {
+ private void doTestSessionStatePaused() {
simulateMediaSessionStateChanged(mTab, true, true);
assertTitleMatches("title1");
simulateUpdateTitle(mTab, "title2");
assertTitleMatches("title2");
}
- private void doTestSessionStateUncontrollable() throws InterruptedException {
+ private void doTestSessionStateUncontrollable() {
simulateMediaSessionStateChanged(mTab, true, false);
assertTitleMatches("title1");
simulateMediaSessionStateChanged(mTab, false, false);
simulateUpdateTitle(mTab, "title2");
}
- private void doTestMediaMetadataSetsTitle() throws InterruptedException {
+ private void doTestMediaMetadataSetsTitle() {
simulateMediaSessionStateChanged(mTab, true, false);
simulateMediaSessionMetadataChanged(mTab, new MediaMetadata("title2", "", ""));
assertTitleMatches("title2");
}
- private void doTestMediaMetadataOverridesTitle() throws InterruptedException {
+ private void doTestMediaMetadataOverridesTitle() {
simulateMediaSessionStateChanged(mTab, true, false);
simulateMediaSessionMetadataChanged(mTab, new MediaMetadata("title2", "", ""));
assertTitleMatches("title2");
@@ -109,12 +109,12 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr
}
@SmallTest
- public void testSessionStatePlaying_MediaStyleNotification() throws InterruptedException {
+ public void testSessionStatePlaying_MediaStyleNotification() {
doTestSessionStatePlaying();
}
@SmallTest
- public void testSessionStatePaused_MediaStyleNotification() throws InterruptedException {
+ public void testSessionStatePaused_MediaStyleNotification() {
doTestSessionStatePaused();
}
@@ -125,13 +125,12 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr
}
@SmallTest
- public void testMediaMetadataSetsTitle_MediaStyleNotification() throws InterruptedException {
+ public void testMediaMetadataSetsTitle_MediaStyleNotification() {
doTestMediaMetadataSetsTitle();
}
@SmallTest
- public void testMediaMetadataOverridesTitle_MediaStyleNotification()
- throws InterruptedException {
+ public void testMediaMetadataOverridesTitle_MediaStyleNotification() {
doTestMediaMetadataOverridesTitle();
}
@@ -186,7 +185,7 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr
}
}
- void assertTitleMatches(final String title) throws InterruptedException {
+ void assertTitleMatches(final String title) {
// The service might still not be created which delays the creation of the notification
// builder.
CriteriaHelper.pollUiThread(new Criteria() {

Powered by Google App Engine
This is Rietveld 408576698