Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java
index e47c9e45e0bf031fd82df302182acccf4b78a305..77dd8b7831e53725717ed1dced1748c038aa2ff9 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java
@@ -33,14 +33,14 @@ public class ToolbarTest extends ChromeActivityTestCaseBase<ChromeActivity> {
startMainActivityOnBlankPage();
}
- private void findInPageFromMenu() throws InterruptedException {
+ private void findInPageFromMenu() {
MenuUtils.invokeCustomMenuActionSync(getInstrumentation(),
getActivity(), R.id.find_in_page_id);
waitForFindInPageVisibility(true);
}
- private void waitForFindInPageVisibility(final boolean visible) throws InterruptedException {
+ private void waitForFindInPageVisibility(final boolean visible) {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
@@ -56,7 +56,7 @@ public class ToolbarTest extends ChromeActivityTestCaseBase<ChromeActivity> {
@MediumTest
@Restriction(ChromeRestriction.RESTRICTION_TYPE_TABLET)
@Feature({"Omnibox"})
- public void testFindInPageDismissedOnOmniboxFocus() throws InterruptedException {
+ public void testFindInPageDismissedOnOmniboxFocus() {
findInPageFromMenu();
UrlBar urlBar = (UrlBar) getActivity().findViewById(R.id.url_bar);

Powered by Google App Engine
This is Rietveld 408576698