Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1961)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
index 6bcb58ef0e977a1115e28ba21883961651c9f637..5e463387ec7039054534ca5508c69adb3931f787 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
@@ -306,7 +306,7 @@ public class AutofillPopupTest extends ChromeActivityTestCaseBase<ChromeActivity
// Wait and assert helper methods -------------------------------------------------------------
private void waitForKeyboardShowRequest(final TestInputMethodManagerWrapper immw,
- final int count) throws InterruptedException {
+ final int count) {
CriteriaHelper.pollUiThread(
Criteria.equals(count, new Callable<Integer>() {
@Override
@@ -316,7 +316,7 @@ public class AutofillPopupTest extends ChromeActivityTestCaseBase<ChromeActivity
}));
}
- private void waitForAnchorViewAdd(final ViewGroup view) throws InterruptedException {
+ private void waitForAnchorViewAdd(final ViewGroup view) {
CriteriaHelper.pollUiThread(new Criteria(
"Autofill Popup anchor view was never added.") {
@Override
@@ -326,7 +326,7 @@ public class AutofillPopupTest extends ChromeActivityTestCaseBase<ChromeActivity
});
}
- private void waitForAutofillPopopShow(final AutofillPopup popup) throws InterruptedException {
+ private void waitForAutofillPopopShow(final AutofillPopup popup) {
CriteriaHelper.pollUiThread(
new Criteria("Autofill Popup anchor view was never added.") {
@Override
@@ -338,7 +338,7 @@ public class AutofillPopupTest extends ChromeActivityTestCaseBase<ChromeActivity
});
}
- private void waitForInputFieldFill(final WebContents webContents) throws InterruptedException {
+ private void waitForInputFieldFill(final WebContents webContents) {
CriteriaHelper.pollInstrumentationThread(
new Criteria("First name field was never filled.") {
@Override

Powered by Google App Engine
This is Rietveld 408576698