Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3811)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
index 7d1dcbe876c04a3b7feedb38c01bfbc1f0849f25..e7c2fb38740af267e78659fd4eb89d56685099bb 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
@@ -88,12 +88,12 @@ public class InstallerDelegateTest extends InstrumentationTestCase
super.tearDown();
}
- private void startMonitoring() throws InterruptedException {
+ private void startMonitoring() {
mTestDelegate.start();
mInstallStarted = true;
}
- private void checkResults(boolean expectedResult) throws InterruptedException {
+ private void checkResults(boolean expectedResult) {
CriteriaHelper.pollInstrumentationThread(new Criteria() {
@Override
public boolean isSatisfied() {
@@ -110,7 +110,7 @@ public class InstallerDelegateTest extends InstrumentationTestCase
* been installed.
*/
@SmallTest
- public void testInstallSuccessful() throws InterruptedException {
+ public void testInstallSuccessful() {
mTestDelegate.setTimingForTests(1, 5000);
startMonitoring();
@@ -126,7 +126,7 @@ public class InstallerDelegateTest extends InstrumentationTestCase
* Tests what happens when the InstallerDelegate task is canceled.
*/
@SmallTest
- public void testInstallWaitUntilCancel() throws InterruptedException {
+ public void testInstallWaitUntilCancel() {
mTestDelegate.setTimingForTests(1, 5000);
startMonitoring();
@@ -142,7 +142,7 @@ public class InstallerDelegateTest extends InstrumentationTestCase
* Tests what happens when the InstallerDelegate times out.
*/
@SmallTest
- public void testInstallTimeout() throws InterruptedException {
+ public void testInstallTimeout() {
mTestDelegate.setTimingForTests(1, 50);
startMonitoring();
checkResults(false);
@@ -153,7 +153,7 @@ public class InstallerDelegateTest extends InstrumentationTestCase
*/
@SmallTest
@RetryOnFailure
- public void testRunnableRaceCondition() throws InterruptedException {
+ public void testRunnableRaceCondition() {
mPackageManager.isInstalled = true;
mTestDelegate.setTimingForTests(1, 5000);
startMonitoring();

Powered by Google App Engine
This is Rietveld 408576698