Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
diff --git a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
index d356b077cb83432e1c274763e57b1114be8975d1..917fe9487073ce3cdc6ef11355d865e1183feea1 100644
--- a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
+++ b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
@@ -144,7 +144,7 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
return account;
}
- protected Account setUpTestAccountAndSignIn() throws InterruptedException {
+ protected Account setUpTestAccountAndSignIn() {
Account account = setUpTestAccount();
signIn(account);
return account;
@@ -159,7 +159,7 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
});
}
- protected void startSyncAndWait() throws InterruptedException {
+ protected void startSyncAndWait() {
startSync();
SyncTestUtil.waitForSyncActive();
}
@@ -174,7 +174,7 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
getInstrumentation().waitForIdleSync();
}
- protected void signIn(final Account account) throws InterruptedException {
+ protected void signIn(final Account account) {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
@@ -204,7 +204,7 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
assertFalse(SyncTestUtil.isSyncRequested());
}
- protected void clearServerData() throws InterruptedException {
+ protected void clearServerData() {
mFakeServerHelper.clearServerData();
SyncTestUtil.triggerSync();
CriteriaHelper.pollUiThread(new Criteria("Timed out waiting for sync to stop.") {
@@ -227,7 +227,7 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
});
}
- protected void pollInstrumentationThread(Criteria criteria) throws InterruptedException {
+ protected void pollInstrumentationThread(Criteria criteria) {
CriteriaHelper.pollInstrumentationThread(
criteria, SyncTestUtil.TIMEOUT_MS, SyncTestUtil.INTERVAL_MS);
}

Powered by Google App Engine
This is Rietveld 408576698