chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java - Issue 2573263002: Catch InterruptedException in CriteriaHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)

Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java

index 79981b44f898f960f2e5a38f4e9ef7622db383e9..12ff2f7d65f915dd2b2fe534f3a22b340cee5288 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java

@@ -84,7 +84,7 @@ public class UsbChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActiv

}

private static void selectItem(final UsbChooserDialogWithFakeNatives chooserDialog,

- int position) throws InterruptedException {

+ int position) {

final Dialog dialog = chooserDialog.mItemChooserDialog.getDialogForTesting();

final ListView items = (ListView) dialog.findViewById(R.id.items);

final Button button = (Button) dialog.findViewById(R.id.positive);

@@ -128,7 +128,7 @@ public class UsbChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActiv

}

@LargeTest

- public void testCancel() throws InterruptedException {

+ public void testCancel() {

Dialog dialog = mChooserDialog.mItemChooserDialog.getDialogForTesting();

assertTrue(dialog.isShowing());