Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java

Issue 2573263002: Catch InterruptedException in CriteriaHelper (Closed)
Patch Set: Change OverviewModeBehaviorWatcher back to try/finally Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
index 5e14dc0c98ceee13ccbe38e600c7c76601f94a7b..cba7f4a7ae0560c3cf7a07d470655771c132a908 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
@@ -270,7 +270,7 @@ public class ModalDialogTest extends ChromeActivityTestCaseBase<ChromeActivity>
*/
@MediumTest
@Feature({"Browser", "Main"})
- public void testDialogDismissedAfterClosingTab() throws InterruptedException {
+ public void testDialogDismissedAfterClosingTab() {
executeJavaScriptAndWaitForDialog("alert('Android')");
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@@ -290,8 +290,7 @@ public class ModalDialogTest extends ChromeActivityTestCaseBase<ChromeActivity>
* Asynchronously executes the given code for spawning a dialog and waits
* for the dialog to be visible.
*/
- private OnEvaluateJavaScriptResultHelper executeJavaScriptAndWaitForDialog(String script)
- throws InterruptedException {
+ private OnEvaluateJavaScriptResultHelper executeJavaScriptAndWaitForDialog(String script) {
return executeJavaScriptAndWaitForDialog(new OnEvaluateJavaScriptResultHelper(), script);
}
@@ -300,8 +299,7 @@ public class ModalDialogTest extends ChromeActivityTestCaseBase<ChromeActivity>
* code for spawning a dialog and waits for the dialog to be visible.
*/
private OnEvaluateJavaScriptResultHelper executeJavaScriptAndWaitForDialog(
- final OnEvaluateJavaScriptResultHelper helper, String script)
- throws InterruptedException {
+ final OnEvaluateJavaScriptResultHelper helper, String script) {
helper.evaluateJavaScriptForTests(
getActivity().getCurrentContentViewCore().getWebContents(),
script);

Powered by Google App Engine
This is Rietveld 408576698