[NOT FOR COMMIT] Fully replace SkCanvas uses.

[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Mac and Linux.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.

 SkCanvas -> CdlCanvas
 SkSurface -> CdlSurface
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint
 SkShader -> CdlShader (supports CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. CdlPassThroughCanvas does pass-through conversion of CdlCanvas commands to SkCanvas.  Only the minimal SkCanvas APIs that are used in Chromium code are implemented.  Most utility canvases e.g. ImageHijackCanvas, MockCanvas, SimCanvas, etc. are now based on CdlCanvas.

GetSkCanvas(CdlCanvas) returns the underlying SkCanvas.  Certain code that needs to reach directly to SkCanvas uses this.

The CdlCanvas drawing API differs from SkCanvas in that all drawing uses CdlPaint, which can be customized going forward.

CdlSurface is a simple wrapper for SkSurface.  This is the root owner of Canvases, so changing CdlSurface ensures all surfaces get CdlCanvas interfaces with the right lifetime.

CdlPictureRecorder produces a recording CdlCanvas interface, and records commands to a display list format (placeholder recording is based on SkLiteDL).  The recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly the same as SkPaint, but supports new CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader respectively _at playback time_.  CdlWrapSkShader is used to pass through any existing SkShaders.

CDL_ENABLE in skia/ext/cdl_common.h can toggle Chromium between Skia & CDL modes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

[vmiura, 2016-11-23 08:13:38]

Description was changed from

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
==========

to

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[vmiura, 2016-11-23 08:13:39]

Description was changed from

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[vmiura, 2016-11-23 08:13:40]

Description was changed from

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-23 18:30:10]

Description was changed from

==========
[NOT FOR COMMIT] Fully replace SkCanvas uses.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is just an SkPaint wrapper for now, but can be customized as we see
fit.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-23 18:31:44]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is just an SkPaint wrapper for now, but can be customized as we see
fit.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is just an SkPaint wrapper for now, but can be customized as we see
fit.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-26 08:48:34]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is just an SkPaint wrapper for now, but can be customized as we see
fit.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShader are implemented, and resolve to SkImageShader
/ SkPictureShader respectively _at playback time_.  CdlWrapSkShader is used to
pass through any existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-26 08:49:28]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShader are implemented, and resolve to SkImageShader
/ SkPictureShader respectively _at playback time_.  CdlWrapSkShader is used to
pass through any existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShader are implemented, and resolve to SkImageShader
/ SkPictureShader respectively _at playback time_.  CdlWrapSkShader is used to
pass through any existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-26 08:53:19]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation does
pass-through conversion to SkCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into SkCanvases.  This will change to
play back into CdlCanvases, and a pass-through can be done to SkCanvas.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShader are implemented, and resolve to SkImageShader
/ SkPictureShader respectively _at playback time_.  CdlWrapSkShader is used to
pass through any existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-26 08:54:25]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-11-26 08:55:29]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder implements the CdlCanvas interface, and records commands to a
display list format (placeholder recording is from SkLiteDL).  The recording
goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is from SkLiteDL).  The
recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2016-11-29 23:41:04]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2016-11-29 23:41:06]

In general, I think this is a good approach.

I am always a bit torn about how long something should live on in a patch/github
branch vs just be landed.  However, it sounds like this improves paint times
and, if landed, would allow for some short term image decode controller
improvements (by turning shaders into saveLayer-esque ops).  It'd also let us
parallelize efforts to clean up paints and pointers a little more easily if it
were landed than if it continued on in patches.

Other than making sure that there's paint team buy in, what are the steps to
getting this landed?


And, apologies for the bikeshedding, but I really need to bikeshed:
(1) Cdl. It's a bit unpronounceable (curdle?), "custom" doesn't contain much
meaning, and it isn't very future proof.  It feels a bit like naming something
"NewDisplayList" which is great right up until the next version of
"NewerDisplayList".  Do you have other suggestions?

(2) CdlLiteDL.  I'm trying to wrap my head around this, but it means that we
have a DisplayItemList which indirectly stores a "custom display list lite
display list"??.  I feel like maybe we have a few too many display lists going
on here.  PaintOpArray is cumbersome but maybe less ambiguous as a suggestion.

[vmiura, 2016-11-30 02:29:41]

On 2016/11/29 23:41:06, enne wrote:
> In general, I think this is a good approach.
> 
> I am always a bit torn about how long something should live on in a
patch/github
> branch vs just be landed.  However, it sounds like this improves paint times
> and, if landed, would allow for some short term image decode controller
> improvements (by turning shaders into saveLayer-esque ops).  It'd also let us
> parallelize efforts to clean up paints and pointers a little more easily if it
> were landed than if it continued on in patches.
>
> Other than making sure that there's paint team buy in, what are the steps to
> getting this landed?

Some TODOs:
 - Make playback caching of generated Sk* objects thread safe.  This needs some
design.
 - Do wider perf tests (e.g. cluster telemetry).
 - Possibly implement RTree in large CdlPictures?  Not sure if display list 2D
canvas needs this or not.
 - Serialization?  I guess if Blimp code is removed we don't need it in the
short term.
 - Unit tests, etc.

Incremental steps to landing:
 1. Land rename patch (typedef to existing SkCanvas).
 2. Land passthrough implementation, still using SkPictures under the hood.
 3. Land new Pictures implementation.


> 
> And, apologies for the bikeshedding, but I really need to bikeshed:
> (1) Cdl. It's a bit unpronounceable (curdle?), "custom" doesn't contain much
> meaning, and it isn't very future proof.  It feels a bit like naming something
> "NewDisplayList" which is great right up until the next version of
> "NewerDisplayList".  Do you have other suggestions?

Yeah... names are hard.

Are we going to put it in cc namespace?

cc::Canvas, in cc/canvas ?
cc::gfx::Canvas in cc/gfx ?

There's already ui::gfx::Canvas...

> 
> (2) CdlLiteDL.  I'm trying to wrap my head around this, but it means that we
> have a DisplayItemList which indirectly stores a "custom display list lite
> display list"??.  I feel like maybe we have a few too many display lists going
> on here.  PaintOpArray is cumbersome but maybe less ambiguous as a suggestion.

Yeah, I think PaintOpArray or PaintOpBuffer would make sense.

[vmiura, 2016-11-30 08:15:53]

There are a number of places marked TODO(cdl).

These aren't difficult, but are needed for feature completeness:

- CdlPicture::playback() ignores SkPicture::AbortCallback.
- CdlPicture::uniqueID() always returns 0.
- CdlPicture::approximateOpCount() always returns 1.
- Need equivalent of SkPictureUtils::ApproximateBytesUsed(SkPicture*).
- Need equivalent of SkPictureGpuAnalyzer
- Need equivalent of annotation APIs (SkAnnotateRectWithURL,
SkAnnotateLinkToDestination, SkAnnotateNamedDestination. Not a blocker.
- Need SkipImageCanvas ported to CdlCanvas (change this to be a flag on
ImageHijackCanvas)
- Need AnalysisCanvas ported to CdlCanvas.
- Need Null Canvas (just wrap an SkNWayCanvas).
- Need CdlPaint::computeFastBounds() and CdlPaint::canComputeFastBounds().

[vmiura, 2016-12-04 08:21:55]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 15ceb3909b88d7d858a47547c9fc03f1eee20776.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is from SkLiteDL).  The
recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is from SkLiteDL).  The
recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-12-04 08:22:28]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Linux.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.


 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is from SkLiteDL).  The
recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Mac.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.

 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is from SkLiteDL).  The
recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-12-10 04:11:08]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Mac.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.

 SkCanvas -> CdlCanvas
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. The default implementation
"CdlCanvas::Make(SkCanvas *)" does pass-through conversion to SkCanvas.  Only
the minimal SkCanvas APIs that are used in Chromium code are implemented. 
ImageHijackCanvas is now based on CdlCanvas.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is from SkLiteDL).  The
recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly a wrapper for SkPaint, but
supports CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Mac.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.

 SkCanvas -> CdlCanvas
 SkSurface -> CdlSurface
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. CdlPassThroughCanvas does pass-through
conversion of CdlCanvas commands to SkCanvas.  Only the minimal SkCanvas APIs
that are used in Chromium code are implemented.  Most utility canvases e.g.
ImageHijackCanvas, MockCanvas, SimCanvas, etc. are now based on CdlCanvas.

GetSkCanvas(CdlCanvas) returns the underlying SkCanvas.  Certain code that needs
to reach directly to SkCanvas uses this.

The CdlCanvas drawing API differs from SkCanvas in that all drawing uses
CdlPaint, which can be customized going forward.

CdlSurface is a simple wrapper for SkSurface.  This is the root owner of
Canvases, so changing CdlSurface ensures all surfaces get CdlCanvas interfaces
with the right lifetime.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is based on SkLiteDL). 
The recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly the same as SkPaint, but
supports new CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CDL_ENABLE in skia/ext/cdl_common.h can toggle Chromium between Skia & CDL
modes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmiura, 2016-12-10 04:12:39]

Description was changed from

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Mac.  Applies to git 1b019f5fd30810ea754f51a4ccd0025234e1fa6c.

 SkCanvas -> CdlCanvas
 SkSurface -> CdlSurface
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint (currently implemented only for drawRect)
 SkShader -> CdlShader (CdlImageShader /CdlPictureShader / CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. CdlPassThroughCanvas does pass-through
conversion of CdlCanvas commands to SkCanvas.  Only the minimal SkCanvas APIs
that are used in Chromium code are implemented.  Most utility canvases e.g.
ImageHijackCanvas, MockCanvas, SimCanvas, etc. are now based on CdlCanvas.

GetSkCanvas(CdlCanvas) returns the underlying SkCanvas.  Certain code that needs
to reach directly to SkCanvas uses this.

The CdlCanvas drawing API differs from SkCanvas in that all drawing uses
CdlPaint, which can be customized going forward.

CdlSurface is a simple wrapper for SkSurface.  This is the root owner of
Canvases, so changing CdlSurface ensures all surfaces get CdlCanvas interfaces
with the right lifetime.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is based on SkLiteDL). 
The recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly the same as SkPaint, but
supports new CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CDL_ENABLE in skia/ext/cdl_common.h can toggle Chromium between Skia & CDL
modes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[NOT FOR COMMIT] Experimental CdlCanvas, CdlPicture and CdlPictureRecorder.

Tested on Mac and Linux.  Applies to git
1b019f5fd30810ea754f51a4ccd0025234e1fa6c.

 SkCanvas -> CdlCanvas
 SkSurface -> CdlSurface
 SkPictureRecorder -> CdlPictureRecorder
 SkPicture -> CdlPicture
 SkPaint -> CdlPaint
 SkShader -> CdlShader (supports CdlImageShader /CdlPictureShader /
CdlWrapSkShader)

CdlCanvas is a replacement for SkCanvas. CdlPassThroughCanvas does pass-through
conversion of CdlCanvas commands to SkCanvas.  Only the minimal SkCanvas APIs
that are used in Chromium code are implemented.  Most utility canvases e.g.
ImageHijackCanvas, MockCanvas, SimCanvas, etc. are now based on CdlCanvas.

GetSkCanvas(CdlCanvas) returns the underlying SkCanvas.  Certain code that needs
to reach directly to SkCanvas uses this.

The CdlCanvas drawing API differs from SkCanvas in that all drawing uses
CdlPaint, which can be customized going forward.

CdlSurface is a simple wrapper for SkSurface.  This is the root owner of
Canvases, so changing CdlSurface ensures all surfaces get CdlCanvas interfaces
with the right lifetime.

CdlPictureRecorder produces a recording CdlCanvas interface, and records
commands to a display list format (placeholder recording is based on SkLiteDL). 
The recording goes into a CdlPicture.

CdlPicture is an object that can paint into CdlCanvases.

CdlPaint is a replacement for SkPaint.  It's mostly the same as SkPaint, but
supports new CdlShaders.

CdlImageShader / CdlPictureShade resolve to SkImageShader / SkPictureShader
respectively _at playback time_.  CdlWrapSkShader is used to pass through any
existing SkShaders.

CDL_ENABLE in skia/ext/cdl_common.h can toggle Chromium between Skia & CDL
modes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========