Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2724)

Unified Diff: content/renderer/pepper/ppb_image_data_impl.h

Issue 2523673004: [NOT FOR COMMIT] Fully replace SkCanvas uses.
Patch Set: Support Android build. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/ppb_image_data_impl.h
diff --git a/content/renderer/pepper/ppb_image_data_impl.h b/content/renderer/pepper/ppb_image_data_impl.h
index 81c9a5a68ebd4631b9c854628a7baf7689392467..10d29b7e1d67d72675ca3bf3866d8ebfba1d1e77 100644
--- a/content/renderer/pepper/ppb_image_data_impl.h
+++ b/content/renderer/pepper/ppb_image_data_impl.h
@@ -16,10 +16,10 @@
#include "ppapi/shared_impl/ppb_image_data_shared.h"
#include "ppapi/shared_impl/resource.h"
#include "ppapi/thunk/ppb_image_data_api.h"
-#include "third_party/skia/include/core/SkCanvas.h"
+#include "skia/ext/cdl_common.h"
+#include "third_party/skia/include/core/SkBitmap.h"
class SkBitmap;
-class SkCanvas;
class TransportDIB;
namespace base {
@@ -51,8 +51,8 @@ class CONTENT_EXPORT PPB_ImageData_Impl
virtual void Unmap() = 0;
virtual int32_t GetSharedMemory(base::SharedMemory** shm,
uint32_t* byte_count) = 0;
- virtual SkCanvas* GetPlatformCanvas() = 0;
- virtual SkCanvas* GetCanvas() = 0;
+ virtual CdlCanvas* GetPlatformCanvas() = 0;
+ virtual CdlCanvas* GetCanvas() = 0;
virtual SkBitmap GetMappedBitmap() const = 0;
};
@@ -97,8 +97,8 @@ class CONTENT_EXPORT PPB_ImageData_Impl
void Unmap() override;
int32_t GetSharedMemory(base::SharedMemory** shm,
uint32_t* byte_count) override;
- SkCanvas* GetPlatformCanvas() override;
- SkCanvas* GetCanvas() override;
+ CdlCanvas* GetPlatformCanvas() override;
+ CdlCanvas* GetCanvas() override;
void SetIsCandidateForReuse() override;
// Returns an *empty* bitmap on error.
@@ -137,8 +137,8 @@ class ImageDataPlatformBackend : public PPB_ImageData_Impl::Backend {
void Unmap() override;
int32_t GetSharedMemory(base::SharedMemory** shm,
uint32_t* byte_count) override;
- SkCanvas* GetPlatformCanvas() override;
- SkCanvas* GetCanvas() override;
+ CdlCanvas* GetPlatformCanvas() override;
+ CdlCanvas* GetCanvas() override;
SkBitmap GetMappedBitmap() const override;
private:
@@ -149,7 +149,7 @@ class ImageDataPlatformBackend : public PPB_ImageData_Impl::Backend {
std::unique_ptr<TransportDIB> dib_;
// When the device is mapped, this is the image. Null when umapped.
- std::unique_ptr<SkCanvas> mapped_canvas_;
+ std::unique_ptr<CdlCanvas> mapped_canvas_;
DISALLOW_COPY_AND_ASSIGN(ImageDataPlatformBackend);
};
@@ -171,15 +171,15 @@ class ImageDataSimpleBackend : public PPB_ImageData_Impl::Backend {
void Unmap() override;
int32_t GetSharedMemory(base::SharedMemory** shm,
uint32_t* byte_count) override;
- SkCanvas* GetPlatformCanvas() override;
- SkCanvas* GetCanvas() override;
+ CdlCanvas* GetPlatformCanvas() override;
+ CdlCanvas* GetCanvas() override;
SkBitmap GetMappedBitmap() const override;
private:
std::unique_ptr<base::SharedMemory> shared_memory_;
// skia_bitmap_ is backed by shared_memory_.
SkBitmap skia_bitmap_;
- std::unique_ptr<SkCanvas> skia_canvas_;
+ std::unique_ptr<CdlCanvas> skia_canvas_;
uint32_t map_count_;
DISALLOW_COPY_AND_ASSIGN(ImageDataSimpleBackend);
« no previous file with comments | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | content/renderer/pepper/ppb_image_data_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698