Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 2523673004: [NOT FOR COMMIT] Fully replace SkCanvas uses.
Patch Set: Support Android build. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
index 2fbf8bbd1fd4e90232942f9620e8d22e1ac56ee9..40db2f99439ffa84904208796f65db116707bd88 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
@@ -61,7 +61,8 @@
#include "platform/graphics/skia/SkiaUtils.h"
#include "platform/text/BidiTextRun.h"
#include "public/platform/Platform.h"
-#include "third_party/skia/include/core/SkCanvas.h"
+#include "skia/ext/cdl_canvas.h"
+#include "skia/ext/cdl_paint.h"
#include "third_party/skia/include/core/SkImageFilter.h"
#include "wtf/MathExtras.h"
#include "wtf/text/StringBuilder.h"
@@ -92,14 +93,14 @@ class CanvasRenderingContext2DAutoRestoreSkCanvas {
CanvasRenderingContext2D* context)
: m_context(context), m_saveCount(0) {
ASSERT(m_context);
- SkCanvas* c = m_context->drawingCanvas();
+ CdlCanvas* c = m_context->drawingCanvas();
if (c) {
m_saveCount = c->getSaveCount();
}
}
~CanvasRenderingContext2DAutoRestoreSkCanvas() {
- SkCanvas* c = m_context->drawingCanvas();
+ CdlCanvas* c = m_context->drawingCanvas();
if (c)
c->restoreToCount(m_saveCount);
m_context->validateStateStack();
@@ -150,7 +151,7 @@ void CanvasRenderingContext2D::dispose() {
void CanvasRenderingContext2D::validateStateStack() const {
#if DCHECK_IS_ON()
- if (SkCanvas* skCanvas = canvas()->existingDrawingCanvas()) {
+ if (CdlCanvas* skCanvas = canvas()->existingDrawingCanvas()) {
// The canvas should always have an initial save frame, to support
// resetting the top level matrix and clip.
DCHECK_GT(skCanvas->getSaveCount(), 1);
@@ -275,7 +276,8 @@ void CanvasRenderingContext2D::reset() {
BaseRenderingContext2D::reset();
}
-void CanvasRenderingContext2D::restoreCanvasMatrixClipStack(SkCanvas* c) const {
+void CanvasRenderingContext2D::restoreCanvasMatrixClipStack(
+ CdlCanvas* c) const {
restoreMatrixClipStack(c);
}
@@ -367,13 +369,13 @@ void CanvasRenderingContext2D::snapshotStateForFilter() {
modifiableState().setFontForFilter(accessFont());
}
-SkCanvas* CanvasRenderingContext2D::drawingCanvas() const {
+CdlCanvas* CanvasRenderingContext2D::drawingCanvas() const {
if (isContextLost())
return nullptr;
return canvas()->drawingCanvas();
}
-SkCanvas* CanvasRenderingContext2D::existingDrawingCanvas() const {
+CdlCanvas* CanvasRenderingContext2D::existingDrawingCanvas() const {
return canvas()->existingDrawingCanvas();
}
@@ -811,7 +813,7 @@ void CanvasRenderingContext2D::drawTextInternal(
// to 0, for example), so update style before grabbing the drawingCanvas.
canvas()->document().updateStyleAndLayoutTreeForNode(canvas());
- SkCanvas* c = drawingCanvas();
+ CdlCanvas* c = drawingCanvas();
if (!c)
return;
@@ -894,8 +896,9 @@ void CanvasRenderingContext2D::drawTextInternal(
draw(
[&font, this, &textRunPaintInfo, &location](
- SkCanvas* c, const SkPaint* paint) // draw lambda
+ CdlCanvas* c, const CdlPaint* paint) // draw lambda
{
+ (void)cDeviceScaleFactor;
font.drawBidiText(c, textRunPaintInfo, location,
Font::UseFallbackIfFontNotReady, cDeviceScaleFactor,
*paint);
@@ -1072,7 +1075,7 @@ void CanvasRenderingContext2D::addHitRegion(const HitRegionOptions& options,
Path hitRegionPath = options.hasPath() ? options.path()->path() : m_path;
- SkCanvas* c = drawingCanvas();
+ CdlCanvas* c = drawingCanvas();
if (hitRegionPath.isEmpty() || !c || !state().isTransformInvertible() ||
!c->getClipDeviceBounds(0)) {

Powered by Google App Engine
This is Rietveld 408576698