Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2418493002: //media/midi: use top level namespace midi rather than media.midi (Closed)

Created:
4 years, 2 months ago by Takashi Toyoshima
Modified:
4 years, 2 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//media/midi: use top level namespace midi rather than media.midi This is a preparation for mojofication that recommends us not to use nested namespace for mojom. With this preparation, C++ code in midi can access midi.mojom namespace conveniently. BUG=582327 Committed: https://crrev.com/59e31971365b1085fc53a60f0c8228894869ae49 Cr-Commit-Position: refs/heads/master@{#424969}

Patch Set 1 #

Patch Set 2 : one more rename to be consistent #

Total comments: 2

Patch Set 3 : TAG name change s/media_midi/midi/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -1314 lines) Patch
M content/app/android/library_loader_hooks.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/midi_host.h View 3 chunks +10 lines, -12 lines 0 comments Download
M content/browser/media/midi_host.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M content/browser/media/midi_host_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/media/midi_messages.h View 3 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 4 chunks +16 lines, -16 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 13 chunks +18 lines, -18 lines 0 comments Download
M content/renderer/media/midi_message_filter_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/midi/BUILD.gn View 1 chunk +13 lines, -13 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/MidiDeviceAndroid.java View 1 chunk +0 lines, -135 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/MidiInputPortAndroid.java View 1 chunk +0 lines, -97 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/MidiManagerAndroid.java View 1 chunk +0 lines, -174 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/MidiOutputPortAndroid.java View 1 chunk +0 lines, -95 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceAndroid.java View 1 chunk +0 lines, -326 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java View 1 chunk +0 lines, -264 lines 0 comments Download
A + media/midi/java/src/org/chromium/midi/MidiDeviceAndroid.java View 2 chunks +3 lines, -3 lines 0 comments Download
A + media/midi/java/src/org/chromium/midi/MidiInputPortAndroid.java View 4 chunks +5 lines, -5 lines 0 comments Download
A + media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java View 4 chunks +6 lines, -6 lines 0 comments Download
A + media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + media/midi/java/src/org/chromium/midi/UsbMidiDeviceAndroid.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + media/midi/java/src/org/chromium/midi/UsbMidiDeviceFactoryAndroid.java View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/midi/midi_device_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_device_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_input_port_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_input_port_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_jni_registrar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/midi/midi_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_mac.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_mac_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_usb.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_win.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_win.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_winrt.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_manager_winrt.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_message_queue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_message_queue.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_message_queue_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_message_util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_message_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_message_util_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_output_port_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_output_port_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_port_info.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_port_info.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_scheduler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/midi_scheduler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/result.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_input_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_input_stream.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_input_stream_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_jack.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_output_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_output_stream.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_output_stream_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
Takashi Toyoshima
michaelbai@chromium.org for library_loader_hooks.cc, and Java package name changes jochen@chromium.org for content/ tsepez@chromium.org for content/common/media/midi_messages.h yhirano@chromium.org ...
4 years, 2 months ago (2016-10-12 06:40:02 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-12 09:38:59 UTC) #5
yhirano
https://codereview.chromium.org/2418493002/diff/20001/media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java File media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java (right): https://codereview.chromium.org/2418493002/diff/20001/media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java#newcode39 media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java:39: private static final String TAG = "media_midi"; Should this ...
4 years, 2 months ago (2016-10-12 11:26:08 UTC) #6
Tom Sepez
RS LGTM on removing namespace from midi_messages.h
4 years, 2 months ago (2016-10-12 16:10:07 UTC) #7
michaelbai
library_loader_hooks.cc, and Java package name LGTM
4 years, 2 months ago (2016-10-13 03:35:15 UTC) #8
Takashi Toyoshima
https://codereview.chromium.org/2418493002/diff/20001/media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java File media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java (right): https://codereview.chromium.org/2418493002/diff/20001/media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java#newcode39 media/midi/java/src/org/chromium/midi/MidiOutputPortAndroid.java:39: private static final String TAG = "media_midi"; Good eyes, ...
4 years, 2 months ago (2016-10-13 05:28:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418493002/40001
4 years, 2 months ago (2016-10-13 05:29:13 UTC) #12
yhirano
lgtm
4 years, 2 months ago (2016-10-13 05:31:11 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 06:43:56 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 06:46:02 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/59e31971365b1085fc53a60f0c8228894869ae49
Cr-Commit-Position: refs/heads/master@{#424969}

Powered by Google App Engine
This is Rietveld 408576698