Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893
patch from issue 2346193002 at patchset 200001 (http://crrev.com/2346193002#ps200001)

Committed: https://crrev.com/90e5a7289784dc5a491a7f1e3a87f30a1eb0bbad
Cr-Commit-Position: refs/heads/master@{#422305}

[esprehn, 2016-10-01 03:29:02]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-10-01 03:29:03]

lgtm

[dcheng, 2016-10-01 03:30:46]

Description was changed from

==========
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)
==========

to

==========
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)
==========

[dcheng, 2016-10-01 03:31:39]

CCing original reviewers.

Cloned from https://codereview.chromium.org/2346193002.

PS1 -> PS2 is auto rebase over the reformat commit (no merge conflicts)
PS2 -> PS3 is clang-format reformat for new code
PS3 -> PS4 is some brace fixes to make check-webkit-style happy

[dcheng, 2016-10-01 03:31:55]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-01 03:32:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 06:03:43]

Description was changed from

==========
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)
==========

to

==========
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)
==========

[commit-bot: I haz the power, 2016-10-01 06:03:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-01 06:05:43]

Description was changed from

==========
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)
==========

to

==========
Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Split CSSPrimitiveValue into two subtypes, CSSPrimitiveValue (for
numerical and calc values) and CSSIdentifierValue (for identifiers).
This is part of a larger effort to split up CSSPrimitiveValue.

This patch is meant to be entirely mechanical changes; if it passes all
tests with no behaviour changes, it has been implemented correctly. The
patch itself was mainly done with find-and-replaces to createKeyword()
and convertTo<>(), then fixing any other errors, sucha as those
resulting from irregular flow (e.g. if (!x.isPrimitiveValue) return;
in CSSToStyleMap) or similar.

The largest change has been to CSSPrimitiveValueMappings.h, since the
convertTo<> method has been moved to CSSIdentifierValue. Also, a
create(Length, zoom) method was added to CSSValue temporarily, and
callers will later change to switch between which create method
(CSSPrimitiveValue or CSSIdentifierValue) they wish to use.

BUG=523893

patch from issue 2346193002 at patchset 200001
(http://crrev.com/2346193002#ps200001)

Committed: https://crrev.com/90e5a7289784dc5a491a7f1e3a87f30a1eb0bbad
Cr-Commit-Position: refs/heads/master@{#422305}
==========

[commit-bot: I haz the power, 2016-10-01 06:05:44]

Patchset 4 (id:??) landed as
https://crrev.com/90e5a7289784dc5a491a7f1e3a87f30a1eb0bbad
Cr-Commit-Position: refs/heads/master@{#422305}