third_party/WebKit/Source/core/dom/TextLinkColors.cpp - Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TextLinkColors.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/TextLinkColors.cpp

diff --git a/third_party/WebKit/Source/core/dom/TextLinkColors.cpp b/third_party/WebKit/Source/core/dom/TextLinkColors.cpp

index 5c0c81cea4f5132fd33807144caed33d7165ad7d..1e1df3e67f75cad9e3eedace8bc854700287e464 100644

--- a/third_party/WebKit/Source/core/dom/TextLinkColors.cpp

+++ b/third_party/WebKit/Source/core/dom/TextLinkColors.cpp

@@ -28,7 +28,7 @@

#include "core/dom/TextLinkColors.h"

#include "core/css/CSSColorValue.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/StyleColor.h"

#include "core/layout/LayoutTheme.h"

#include "wtf/text/WTFString.h"

@@ -59,7 +59,7 @@ Color TextLinkColors::colorFromCSSValue(const CSSValue& value,

if (value.isColorValue())

return toCSSColorValue(value).value();

- CSSValueID valueID = toCSSPrimitiveValue(value).getValueID();

+ CSSValueID valueID = toCSSIdentifierValue(value).getValueID();

switch (valueID) {

case CSSValueInvalid:

NOTREACHED();