Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
index 3d997999d0efdcf56326113418a5ea94fb7149d0..17fe07c81c43430ea5340cb02e675fb909cd309d 100644
--- a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
@@ -5,6 +5,7 @@
#include "core/animation/CSSClipInterpolationType.h"
#include "core/animation/LengthInterpolationFunctions.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSQuadValue.h"
#include "core/css/resolver/StyleResolverState.h"
#include "wtf/PtrUtil.h"
@@ -189,12 +190,13 @@ InterpolationValue CSSClipInterpolationType::maybeConvertInherit(
state.parentStyle()->effectiveZoom());
}
-static bool isCSSAuto(const CSSPrimitiveValue& value) {
- return value.getValueID() == CSSValueAuto;
+static bool isCSSAuto(const CSSValue& value) {
+ return value.isIdentifierValue() &&
+ toCSSIdentifierValue(value).getValueID() == CSSValueAuto;
}
static std::unique_ptr<InterpolableValue> convertClipComponent(
- const CSSPrimitiveValue& length) {
+ const CSSValue& length) {
if (isCSSAuto(length))
return InterpolableList::create(0);
return LengthInterpolationFunctions::maybeConvertCSSValue(length)

Powered by Google App Engine
This is Rietveld 408576698