third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp - Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

index 15196fc241fac4c5729ec675a92f7385e9688ec2..a53ef77b059930593e6ce1595a4bcbd64e7651f6 100644

--- a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

@@ -135,17 +135,17 @@ InterpolationValue CSSVisibilityInterpolationType::maybeConvertValue(

const CSSValue& value,

const StyleResolverState& state,

ConversionCheckers& conversionCheckers) const {

- if (!value.isPrimitiveValue())

+ if (!value.isIdentifierValue())

return nullptr;

- const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);

- CSSValueID keyword = primitiveValue.getValueID();

+ const CSSIdentifierValue& identifierValue = toCSSIdentifierValue(value);

+ CSSValueID keyword = identifierValue.getValueID();

switch (keyword) {

case CSSValueHidden:

case CSSValueVisible:

case CSSValueCollapse:

- return createVisibilityValue(primitiveValue.convertTo<EVisibility>());

+ return createVisibilityValue(identifierValue.convertTo<EVisibility>());

default:

return nullptr;

}