third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp - Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

index 26795607f4edae26d079e7ef2eb0396ada7b87c3..a464c2d836963e2442208589a77dff27f825e96a 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

@@ -4,7 +4,7 @@

#include "core/css/parser/CSSParserFastPaths.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/CSSValueList.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -14,10 +14,9 @@ TEST(CSSParserFastPathsTest, ParseKeyword) {

CSSValue* value = CSSParserFastPaths::maybeParseValue(

CSSPropertyFloat, "left", HTMLStandardMode);

ASSERT_NE(nullptr, value);

- EXPECT_TRUE(value->isPrimitiveValue());

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

- EXPECT_TRUE(primitiveValue->isValueID());

- EXPECT_EQ(CSSValueLeft, primitiveValue->getValueID());

+ EXPECT_TRUE(value->isIdentifierValue());

+ CSSIdentifierValue* identifierValue = toCSSIdentifierValue(value);

+ EXPECT_EQ(CSSValueLeft, identifierValue->getValueID());

value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "foo",

HTMLStandardMode);

ASSERT_EQ(nullptr, value);