third_party/WebKit/Source/core/css/CSSCalculationValue.cpp - Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp b/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

index ca71c391e88907492bb346c0019462bb6733cc94..f2554043f480bd4515f4b0051a2a37f943cf12e5 100644

--- a/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

@@ -119,7 +119,6 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitType type) {

case CSSPrimitiveValue::UnitType::CalcPercentageWithLength:

case CSSPrimitiveValue::UnitType::CalcLengthWithNumber:

case CSSPrimitiveValue::UnitType::CalcPercentageWithLengthAndNumber:

- case CSSPrimitiveValue::UnitType::ValueID:

case CSSPrimitiveValue::UnitType::QuirkyEms:

return false;

};