Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: third_party/WebKit/Source/core/css/CSSContentDistributionValue.h

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSContentDistributionValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSContentDistributionValue.h b/third_party/WebKit/Source/core/css/CSSContentDistributionValue.h
index 9ad07022b26dc14662bdc871be63c5ce8ccaf37c..b818db8363ee056bcd8d19feaa024d451b66e88f 100644
--- a/third_party/WebKit/Source/core/css/CSSContentDistributionValue.h
+++ b/third_party/WebKit/Source/core/css/CSSContentDistributionValue.h
@@ -5,7 +5,7 @@
#ifndef CSSContentDistributionValue_h
#define CSSContentDistributionValue_h
-#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSValue.h"
#include "wtf/RefPtr.h"
@@ -20,16 +20,17 @@ class CSSContentDistributionValue : public CSSValue {
}
~CSSContentDistributionValue();
- CSSPrimitiveValue* distribution() const {
- return CSSPrimitiveValue::createIdentifier(m_distribution);
+ // TODO(sashab): Make these return CSSValueIDs instead of CSSValues.
+ CSSIdentifierValue* distribution() const {
+ return CSSIdentifierValue::create(m_distribution);
}
- CSSPrimitiveValue* position() const {
- return CSSPrimitiveValue::createIdentifier(m_position);
+ CSSIdentifierValue* position() const {
+ return CSSIdentifierValue::create(m_position);
}
- CSSPrimitiveValue* overflow() const {
- return CSSPrimitiveValue::createIdentifier(m_overflow);
+ CSSIdentifierValue* overflow() const {
+ return CSSIdentifierValue::create(m_overflow);
}
String customCSSText() const;

Powered by Google App Engine
This is Rietveld 408576698