third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp - Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

index 637f64a610bab7dbd8fa2712e8b68c85a1fe8e0f..392307019f3e6eb80e9f3673006a3c6f635c3948 100644

--- a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

@@ -106,8 +106,7 @@ void TransformBuilder::createTransformOperations(

TransformOperations& outOperations) {

ASSERT(!outOperations.size());

if (!inValue.isValueList()) {

- ASSERT(inValue.isPrimitiveValue() &&

- toCSSPrimitiveValue(inValue).getValueID() == CSSValueNone);

+ DCHECK_EQ(toCSSIdentifierValue(inValue).getValueID(), CSSValueNone);

return;

}