Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/WebKit/Source/core/css/CSSCounterValue.h

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSCounterValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSCounterValue.h b/third_party/WebKit/Source/core/css/CSSCounterValue.h
index a20d85082d4c40d719a867e72139048baac631c1..2d8b025523d819dbcac92d2ca22cef7a020023b8 100644
--- a/third_party/WebKit/Source/core/css/CSSCounterValue.h
+++ b/third_party/WebKit/Source/core/css/CSSCounterValue.h
@@ -22,7 +22,7 @@
#define CSSCounterValue_h
#include "core/css/CSSCustomIdentValue.h"
-#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSStringValue.h"
#include "wtf/text/WTFString.h"
@@ -31,7 +31,7 @@ namespace blink {
class CSSCounterValue : public CSSValue {
public:
static CSSCounterValue* create(CSSCustomIdentValue* identifier,
- CSSPrimitiveValue* listStyle,
+ CSSIdentifierValue* listStyle,
CSSStringValue* separator) {
return new CSSCounterValue(identifier, listStyle, separator);
}
@@ -51,17 +51,15 @@ class CSSCounterValue : public CSSValue {
private:
CSSCounterValue(CSSCustomIdentValue* identifier,
- CSSPrimitiveValue* listStyle,
+ CSSIdentifierValue* listStyle,
CSSStringValue* separator)
: CSSValue(CounterClass),
m_identifier(identifier),
m_listStyle(listStyle),
- m_separator(separator) {
- ASSERT(m_listStyle->isValueID());
- }
+ m_separator(separator) {}
Member<CSSCustomIdentValue> m_identifier; // string
- Member<CSSPrimitiveValue> m_listStyle; // ident
+ Member<CSSIdentifierValue> m_listStyle; // ident
Member<CSSStringValue> m_separator; // string
};

Powered by Google App Engine
This is Rietveld 408576698