Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSCounterValue.h

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #ifndef CSSCounterValue_h 21 #ifndef CSSCounterValue_h
22 #define CSSCounterValue_h 22 #define CSSCounterValue_h
23 23
24 #include "core/css/CSSCustomIdentValue.h" 24 #include "core/css/CSSCustomIdentValue.h"
25 #include "core/css/CSSPrimitiveValue.h" 25 #include "core/css/CSSIdentifierValue.h"
26 #include "core/css/CSSStringValue.h" 26 #include "core/css/CSSStringValue.h"
27 #include "wtf/text/WTFString.h" 27 #include "wtf/text/WTFString.h"
28 28
29 namespace blink { 29 namespace blink {
30 30
31 class CSSCounterValue : public CSSValue { 31 class CSSCounterValue : public CSSValue {
32 public: 32 public:
33 static CSSCounterValue* create(CSSCustomIdentValue* identifier, 33 static CSSCounterValue* create(CSSCustomIdentValue* identifier,
34 CSSPrimitiveValue* listStyle, 34 CSSIdentifierValue* listStyle,
35 CSSStringValue* separator) { 35 CSSStringValue* separator) {
36 return new CSSCounterValue(identifier, listStyle, separator); 36 return new CSSCounterValue(identifier, listStyle, separator);
37 } 37 }
38 38
39 String identifier() const { return m_identifier->value(); } 39 String identifier() const { return m_identifier->value(); }
40 CSSValueID listStyle() const { return m_listStyle->getValueID(); } 40 CSSValueID listStyle() const { return m_listStyle->getValueID(); }
41 String separator() const { return m_separator->value(); } 41 String separator() const { return m_separator->value(); }
42 42
43 bool equals(const CSSCounterValue& other) const { 43 bool equals(const CSSCounterValue& other) const {
44 return identifier() == other.identifier() && 44 return identifier() == other.identifier() &&
45 listStyle() == other.listStyle() && separator() == other.separator(); 45 listStyle() == other.listStyle() && separator() == other.separator();
46 } 46 }
47 47
48 String customCSSText() const; 48 String customCSSText() const;
49 49
50 DECLARE_TRACE_AFTER_DISPATCH(); 50 DECLARE_TRACE_AFTER_DISPATCH();
51 51
52 private: 52 private:
53 CSSCounterValue(CSSCustomIdentValue* identifier, 53 CSSCounterValue(CSSCustomIdentValue* identifier,
54 CSSPrimitiveValue* listStyle, 54 CSSIdentifierValue* listStyle,
55 CSSStringValue* separator) 55 CSSStringValue* separator)
56 : CSSValue(CounterClass), 56 : CSSValue(CounterClass),
57 m_identifier(identifier), 57 m_identifier(identifier),
58 m_listStyle(listStyle), 58 m_listStyle(listStyle),
59 m_separator(separator) { 59 m_separator(separator) {}
60 ASSERT(m_listStyle->isValueID());
61 }
62 60
63 Member<CSSCustomIdentValue> m_identifier; // string 61 Member<CSSCustomIdentValue> m_identifier; // string
64 Member<CSSPrimitiveValue> m_listStyle; // ident 62 Member<CSSIdentifierValue> m_listStyle; // ident
65 Member<CSSStringValue> m_separator; // string 63 Member<CSSStringValue> m_separator; // string
66 }; 64 };
67 65
68 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCounterValue, isCounterValue()); 66 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCounterValue, isCounterValue());
69 67
70 } // namespace blink 68 } // namespace blink
71 69
72 #endif // CSSCounterValue_h 70 #endif // CSSCounterValue_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698