Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/core/css/CSSValuePool.h

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSValuePool.h
diff --git a/third_party/WebKit/Source/core/css/CSSValuePool.h b/third_party/WebKit/Source/core/css/CSSValuePool.h
index 2c516d34ac1bc1dedab072393ea2168c576eb76b..217b0cbe4f145c04e94282aae89596b51308b7f6 100644
--- a/third_party/WebKit/Source/core/css/CSSValuePool.h
+++ b/third_party/WebKit/Source/core/css/CSSValuePool.h
@@ -32,6 +32,7 @@
#include "core/css/CSSColorValue.h"
#include "core/css/CSSCustomIdentValue.h"
#include "core/css/CSSFontFamilyValue.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSInheritedValue.h"
#include "core/css/CSSInitialValue.h"
#include "core/css/CSSPrimitiveValue.h"
@@ -66,12 +67,12 @@ class CORE_EXPORT CSSValuePool
CSSInitialValue* explicitInitialValue() { return m_explicitInitialValue; }
CSSUnsetValue* unsetValue() { return m_unsetValue; }
- // CSSPrimitiveValue vector caches.
- CSSPrimitiveValue* identifierCacheValue(CSSValueID ident) {
+ // Vector caches.
+ CSSIdentifierValue* identifierCacheValue(CSSValueID ident) {
return m_identifierValueCache[ident];
}
- CSSPrimitiveValue* setIdentifierCacheValue(CSSValueID ident,
- CSSPrimitiveValue* cssValue) {
+ CSSIdentifierValue* setIdentifierCacheValue(CSSValueID ident,
+ CSSIdentifierValue* cssValue) {
return m_identifierValueCache[ident] = cssValue;
}
CSSPrimitiveValue* pixelCacheValue(int intValue) {
@@ -129,8 +130,8 @@ class CORE_EXPORT CSSValuePool
Member<CSSColorValue> m_colorWhite;
Member<CSSColorValue> m_colorBlack;
- // CSSPrimitiveValue vector caches.
- HeapVector<Member<CSSPrimitiveValue>, numCSSValueKeywords>
+ // Vector caches.
+ HeapVector<Member<CSSIdentifierValue>, numCSSValueKeywords>
m_identifierValueCache;
HeapVector<Member<CSSPrimitiveValue>, maximumCacheableIntegerValue + 1>
m_pixelValueCache;
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSValue.cpp ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698