third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp - Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

index 91f5a2a444d6a044b91102e7dea558207d061c87..3c053b8fd196645e23281cf616af2766ac2a98ca 100644

--- a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

@@ -5,6 +5,7 @@

#include "core/animation/CSSPathInterpolationType.h"

#include "core/animation/PathInterpolationFunctions.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/CSSPathValue.h"

#include "core/css/resolver/StyleResolverState.h"

#include "wtf/PtrUtil.h"

@@ -87,7 +88,7 @@ InterpolationValue CSSPathInterpolationType::maybeConvertValue(

const StyleResolverState& state,

ConversionCheckers& conversionCheckers) const {

if (!value.isPathValue()) {

- DCHECK_EQ(toCSSPrimitiveValue(value).getValueID(), CSSValueNone);

+ DCHECK_EQ(toCSSIdentifierValue(value).getValueID(), CSSValueNone);

return nullptr;

}

return PathInterpolationFunctions::convertValue(