Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index acc1965c2d715a689f46d71e2bab3f781ec3a85f..a0447552048e19013937195f23296082208df196 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -45,6 +45,7 @@
#include "core/css/CSSCustomIdentValue.h"
#include "core/css/CSSDefaultStyleSheets.h"
#include "core/css/CSSFontSelector.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSKeyframeRule.h"
#include "core/css/CSSKeyframesRule.h"
#include "core/css/CSSReflectValue.h"
@@ -853,8 +854,8 @@ PassRefPtr<ComputedStyle> StyleResolver::styleForElement(
for (auto it = properties.begin(); it != properties.end(); ++it) {
const CSSValue* value =
it->properties->getPropertyCSSValue(CSSPropertyDisplay);
- if (value && value->isPrimitiveValue() &&
- toCSSPrimitiveValue(*value).getValueID() == CSSValueBlock)
+ if (value && value->isIdentifierValue() &&
+ toCSSIdentifierValue(*value).getValueID() == CSSValueBlock)
UseCounter::count(
element->document(),
UseCounter::SummaryElementWithDisplayBlockAuthorRule);

Powered by Google App Engine
This is Rietveld 408576698