Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index b5ce1cc7d18ac0ea4dcb81966369d2e874fdb78f..270b58da73fdffcc85911256061fb14a25bbc8bf 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -33,6 +33,7 @@
#include "core/CSSValueKeywords.h"
#include "core/HTMLNames.h"
#include "core/clipboard/Pasteboard.h"
+#include "core/css/CSSIdentifierValue.h"
#include "core/css/CSSValueList.h"
#include "core/css/StylePropertySet.h"
#include "core/dom/DocumentFragment.h"
@@ -1653,8 +1654,8 @@ static bool executeStrikethrough(LocalFrame& frame,
Event*,
EditorCommandSource source,
const String&) {
- CSSPrimitiveValue* lineThrough =
- CSSPrimitiveValue::createIdentifier(CSSValueLineThrough);
+ CSSIdentifierValue* lineThrough =
+ CSSIdentifierValue::create(CSSValueLineThrough);
return executeToggleStyleInList(
frame, source, InputEvent::InputType::StrikeThrough,
CSSPropertyWebkitTextDecorationsInEffect, lineThrough);
@@ -1733,8 +1734,7 @@ static bool executeUnderline(LocalFrame& frame,
Event*,
EditorCommandSource source,
const String&) {
- CSSPrimitiveValue* underline =
- CSSPrimitiveValue::createIdentifier(CSSValueUnderline);
+ CSSIdentifierValue* underline = CSSIdentifierValue::create(CSSValueUnderline);
return executeToggleStyleInList(
frame, source, InputEvent::InputType::Underline,
CSSPropertyWebkitTextDecorationsInEffect, underline);

Powered by Google App Engine
This is Rietveld 408576698