Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.h

Issue 2382653006: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Make check-webkit-style happy Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSValue.h b/third_party/WebKit/Source/core/css/CSSValue.h
index bec0cac9a9a3f8f34640038408e37a88455adfeb..8083104b0cb8de30ff8a92810027a013680217aa 100644
--- a/third_party/WebKit/Source/core/css/CSSValue.h
+++ b/third_party/WebKit/Source/core/css/CSSValue.h
@@ -27,6 +27,8 @@
namespace blink {
+class Length;
+
class CORE_EXPORT CSSValue : public GarbageCollectedFinalized<CSSValue> {
public:
// Override operator new to allocate CSSValue subtype objects onto
@@ -43,9 +45,13 @@ class CORE_EXPORT CSSValue : public GarbageCollectedFinalized<CSSValue> {
GCInfoTrait<CSSValue>::index(), typeName);
}
+ // TODO(sashab): Remove this method and move logic to the caller.
+ static CSSValue* create(const Length& value, float zoom);
+
String cssText() const;
bool isPrimitiveValue() const { return m_classType == PrimitiveClass; }
+ bool isIdentifierValue() const { return m_classType == IdentifierClass; }
bool isValuePair() const { return m_classType == ValuePairClass; }
bool isValueList() const { return m_classType >= ValueListClass; }
@@ -156,6 +162,7 @@ class CORE_EXPORT CSSValue : public GarbageCollectedFinalized<CSSValue> {
static const size_t ClassTypeBits = 6;
enum ClassType {
PrimitiveClass,
+ IdentifierClass,
ColorClass,
CounterClass,
QuadClass,
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSShadowValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698