Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2265563002: Shuffles around immersive related classes (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@immersive_pure_virtual
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shuffles around immersive related classes All the shared classes are now in ash/shared. WmImmersive* has been nuked as it's no longer necessary. WmShell creates ImmersiveContextAsh as it works with mus and aura. I will make WmShell create ImmersiveFullscreenController directly soonish. I need https://codereview.chromium.org/2248263003/ to land first though. BUG=548435 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/228c74f7599b1d36139856737a0e26feccb4d372 Cr-Commit-Position: refs/heads/master@{#413227}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : merge to trunk #

Patch Set 4 : move comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -1352 lines) Patch
M ash/ash.gyp View 3 chunks +9 lines, -10 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/aura/wm_window_aura.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/DEPS View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/ash_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/ash_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/frame/custom_frame_view_ash.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/frame/custom_frame_view_ash.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ash/common/frame/header_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/frame/header_view.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/common/wm/immersive/wm_immersive_fullscreen_controller.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ash/common/wm/immersive/wm_immersive_fullscreen_controller_delegate.h View 1 chunk +0 lines, -47 lines 0 comments Download
A + ash/common/wm/immersive_context_ash.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/immersive_context_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/common/wm/immersive_revealed_lock.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ash/common/wm/immersive_revealed_lock.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M ash/common/wm_shell.h View 1 4 chunks +4 lines, -2 lines 0 comments Download
M ash/common/wm_shell.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M ash/common/wm_window.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/shared/immersive_fullscreen_controller.h View 1 2 3 4 chunks +45 lines, -14 lines 0 comments Download
A + ash/shared/immersive_fullscreen_controller.cc View 1 2 3 3 chunks +8 lines, -10 lines 0 comments Download
A + ash/shared/immersive_fullscreen_controller_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ash/shared/immersive_handler_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/shared/immersive_handler_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/shared/immersive_revealed_lock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/shared/immersive_revealed_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/test/immersive_fullscreen_controller_test_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/wm/immersive_context_ash.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ash/wm/immersive_context_ash.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M ash/wm/immersive_focus_watcher_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/immersive_fullscreen_controller.h View 1 chunk +0 lines, -247 lines 0 comments Download
D ash/wm/immersive_fullscreen_controller.cc View 1 chunk +0 lines, -655 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/immersive_gesture_handler_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/immersive_handler_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ash/wm/immersive_handler_factory.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ash/wm/immersive_handler_factory_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_handle_window_targeter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/resize_handle_window_targeter.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sky
4 years, 4 months ago (2016-08-19 17:45:29 UTC) #2
James Cook
LGTM https://codereview.chromium.org/2265563002/diff/20001/ash/shared/immersive_fullscreen_controller.cc File ash/shared/immersive_fullscreen_controller.cc (right): https://codereview.chromium.org/2265563002/diff/20001/ash/shared/immersive_fullscreen_controller.cc#newcode65 ash/shared/immersive_fullscreen_controller.cc:65: // static nit: Either put the comment here ...
4 years, 4 months ago (2016-08-19 18:15:17 UTC) #3
sky
https://codereview.chromium.org/2265563002/diff/20001/ash/shared/immersive_fullscreen_controller.cc File ash/shared/immersive_fullscreen_controller.cc (right): https://codereview.chromium.org/2265563002/diff/20001/ash/shared/immersive_fullscreen_controller.cc#newcode65 ash/shared/immersive_fullscreen_controller.cc:65: // static On 2016/08/19 18:15:16, James Cook (slow reviews) ...
4 years, 4 months ago (2016-08-19 19:25:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265563002/60001
4 years, 4 months ago (2016-08-19 19:26:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-19 20:18:33 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 20:22:34 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/228c74f7599b1d36139856737a0e26feccb4d372
Cr-Commit-Position: refs/heads/master@{#413227}

Powered by Google App Engine
This is Rietveld 408576698