Re-write many calls to WrapUnique() with MakeUnique()

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
Committed: https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7
Cr-Commit-Position: refs/heads/master@{#415247}

[Adam Rice, 2016-08-18 10:21:02]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 10:21:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 11:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 11:57:58]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-08-19 07:41:35]

ricea@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Adam Rice, 2016-08-29 07:04:23]

Devlin: would you like me to re-assign?

[Devlin, 2016-08-29 14:29:45]

On 2016/08/29 07:04:23, Adam Rice wrote:
> Devlin: would you like me to re-assign?

Sorry for the delay!  Will make sure to get to this today.  (In the future, feel
free to ping after 24 hrs of non-response. :))

[Devlin, 2016-08-29 15:10:01]

lgtm

There were a few places where we're rewriting the whole line of a
std::unique_ptr(new Foo()) and could change it to use MakeUnique as well, but
that might very well be out of scope for this change.  If so, feel free to
ignore those comments.

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/omnibox/omnibox_api.cc (right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:108: std::unique_ptr<Event>
event(new Event(events::OMNIBOX_ON_INPUT_STARTED,
optional: use MakeUnique here?

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:178: std::unique_ptr<Event>
event(new Event(events::OMNIBOX_ON_INPUT_CANCELLED,
ditto

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
(right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/storage/policy_value_store_unittest.cc:54:
base::MakeUnique<LeveldbValueStore>(kDatabaseUMAClientName, path)) {
I thought git cl format preferred empty methods to be {}?

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tabs/windows_event_router.cc (right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tabs/windows_event_router.cc:255:
std::unique_ptr<Event> event(new Event(events::WINDOWS_ON_FOCUS_CHANGED,
MakeUnique

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
(right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc:100:
new Event(events::WEBRTC_AUDIO_PRIVATE_ON_SINKS_CHANGED, kEventName,
MakeUnique

[Adam Rice, 2016-08-30 06:42:48]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-08-30 06:42:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2257113002/#ps20001
(title: "Rewrite unique_ptr<Event> initialisations")

[commit-bot: I haz the power, 2016-08-30 06:43:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 06:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 06:45:50]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Adam Rice, 2016-08-30 07:03:00]

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/omnibox/omnibox_api.cc (right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:108: std::unique_ptr<Event>
event(new Event(events::OMNIBOX_ON_INPUT_STARTED,
On 2016/08/29 15:10:01, Devlin wrote:
> optional: use MakeUnique here?

Done.

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:178: std::unique_ptr<Event>
event(new Event(events::OMNIBOX_ON_INPUT_CANCELLED,
On 2016/08/29 15:10:01, Devlin wrote:
> ditto

Done.

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
(right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/storage/policy_value_store_unittest.cc:54:
base::MakeUnique<LeveldbValueStore>(kDatabaseUMAClientName, path)) {
On 2016/08/29 15:10:01, Devlin wrote:
> I thought git cl format preferred empty methods to be {}?

I think it wrapped like this because '{' is the 80th character on the line.

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tabs/windows_event_router.cc (right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tabs/windows_event_router.cc:255:
std::unique_ptr<Event> event(new Event(events::WINDOWS_ON_FOCUS_CHANGED,
On 2016/08/29 15:10:01, Devlin wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
(right):

https://codereview.chromium.org/2257113002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc:100:
new Event(events::WEBRTC_AUDIO_PRIVATE_ON_SINKS_CHANGED, kEventName,
On 2016/08/29 15:10:01, Devlin wrote:
> MakeUnique

Done.

[Adam Rice, 2016-08-30 07:52:33]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-08-30 07:52:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2257113002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-30 07:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 08:47:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 08:49:16]

Description was changed from

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
==========

to

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Committed: https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7
Cr-Commit-Position: refs/heads/master@{#415247}
==========

[commit-bot: I haz the power, 2016-08-30 08:49:17]

Patchset 3 (id:??) landed as
https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7
Cr-Commit-Position: refs/heads/master@{#415247}