chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/counting_policy_unittest.cc ('k') | chrome/browser/extensions/api/autofill_private/autofill_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

index bb65a95478b9e6da979232ec5a2880989e7a76b2..236d43ef9f2e47568eddcc6ffc5b5479f2202c00 100644

--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

@@ -378,14 +378,14 @@ TEST_F(FullStreamUIPolicyTest, LogAndFetchActions) {

base::Time::Now(),

Action::ACTION_API_CALL,

"tabs.testMethod");

- action_api->set_args(base::WrapUnique(new base::ListValue()));

+ action_api->set_args(base::MakeUnique<base::ListValue>());

policy->ProcessAction(action_api);

scoped_refptr<Action> action_dom = new Action(extension->id(),

base::Time::Now(),

Action::ACTION_DOM_ACCESS,

"document.write");

- action_dom->set_args(base::WrapUnique(new base::ListValue()));

+ action_dom->set_args(base::MakeUnique<base::ListValue>());

action_dom->set_page_url(gurl);

policy->ProcessAction(action_dom);

@@ -417,14 +417,14 @@ TEST_F(FullStreamUIPolicyTest, LogAndFetchFilteredActions) {

base::Time::Now(),

Action::ACTION_API_CALL,

"tabs.testMethod");

- action_api->set_args(base::WrapUnique(new base::ListValue()));

+ action_api->set_args(base::MakeUnique<base::ListValue>());

policy->ProcessAction(action_api);

scoped_refptr<Action> action_dom = new Action(extension->id(),

base::Time::Now(),

Action::ACTION_DOM_ACCESS,

"document.write");

- action_dom->set_args(base::WrapUnique(new base::ListValue()));

+ action_dom->set_args(base::MakeUnique<base::ListValue>());

action_dom->set_page_url(gurl);

policy->ProcessAction(action_dom);

@@ -858,14 +858,14 @@ TEST_F(FullStreamUIPolicyTest, DeleteDatabase) {

base::Time::Now(),

Action::ACTION_API_CALL,

"tabs.testMethod");

- action_api->set_args(base::WrapUnique(new base::ListValue()));

+ action_api->set_args(base::MakeUnique<base::ListValue>());

policy->ProcessAction(action_api);

scoped_refptr<Action> action_dom = new Action(extension->id(),

base::Time::Now(),

Action::ACTION_DOM_ACCESS,

"document.write");

- action_dom->set_args(base::WrapUnique(new base::ListValue()));

+ action_dom->set_args(base::MakeUnique<base::ListValue>());

action_dom->set_page_url(gurl);

policy->ProcessAction(action_dom);