chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api_helpers.cc ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

index f9a59ae9639037b6db03c96bca4e0e547a64db08..6b79c87a04d6a91f30f7932a3fbe41843bbf2ef3 100644

--- a/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

@@ -396,7 +396,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithoutPermissionPlatformKeysTest,

// To verify that the user is not prompted for any certificate selection,

// set up a delegate that fails on any invocation.

GetPlatformKeysService()->SetSelectDelegate(

- base::WrapUnique(new TestSelectDelegate(net::CertificateList())));

+ base::MakeUnique<TestSelectDelegate>(net::CertificateList()));

ASSERT_TRUE(RunExtensionTest("managedProfile")) << message_;

}

@@ -433,7 +433,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithPermissionPlatformKeysTest,

certs.push_back(client_cert1_);

GetPlatformKeysService()->SetSelectDelegate(

- base::WrapUnique(new TestSelectDelegate(certs)));

+ base::MakeUnique<TestSelectDelegate>(certs));

ASSERT_TRUE(RunExtensionTest("corporateKeyWithPermissionTests")) << message_;

}

@@ -444,7 +444,7 @@ IN_PROC_BROWSER_TEST_P(ManagedWithPermissionPlatformKeysTest,

// As the profile is managed, the user must not be able to grant any

// certificate permission. Set up a delegate that fails on any invocation.

GetPlatformKeysService()->SetSelectDelegate(

- base::WrapUnique(new TestSelectDelegate(net::CertificateList())));

+ base::MakeUnique<TestSelectDelegate>(net::CertificateList()));

ASSERT_TRUE(RunExtensionTest("policyDoesGrantAccessToNonCorporateKey"))

<< message_;