chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api_unittest.cc ('k') | chrome/browser/extensions/api/storage/policy_value_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

index 38add751841116160ac32f67469bfb57d1e922a3..7801b0d81ef548d863dbdd80b421eef3c21089ab 100644

--- a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

+++ b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

@@ -23,13 +23,13 @@ namespace api {

static std::unique_ptr<KeyedService> ApiResourceManagerTestFactory(

content::BrowserContext* context) {

- return base::WrapUnique(new ApiResourceManager<ResumableTCPSocket>(context));

+ return base::MakeUnique<ApiResourceManager<ResumableTCPSocket>>(context);

}

static std::unique_ptr<KeyedService> ApiResourceManagerTestServerFactory(

content::BrowserContext* context) {

- return base::WrapUnique(

- new ApiResourceManager<ResumableTCPServerSocket>(context));

+ return base::MakeUnique<ApiResourceManager<ResumableTCPServerSocket>>(

+ context);

}

class SocketsTcpServerUnitTest : public ExtensionApiUnittest {